[PATCH BlueZ] shared/bap: Transition ASE to QoS Configured on CIS loss

[PATCH BlueZ] shared/bap: Transition ASE to QoS Configured on CIS loss

[Simon Mikuda]

stream_io_disconnected() only handled the Releasing state, leaving
Enabling, Streaming and Disabling ASEs stuck when the CIS was lost
unexpectedly. The ASE shall autonomously move to QoS Configured on loss
of the CIS and notify the peer; add that transition.

Fixes PTS test BAP/USR/SCC/BV-167-C
---
 src/shared/bap.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/shared/bap.c b/src/shared/bap.c
index deb85b264..350ed53d9 100644
--- a/src/shared/bap.c
+++ b/src/shared/bap.c
@@ -6779,6 +6779,14 @@ static bool stream_io_disconnected(struct io *io, void *user_data)
 	if (stream->ep->state == BT_ASCS_ASE_STATE_RELEASING)
 		stream_set_state(stream, BT_BAP_STREAM_STATE_CONFIG);
 
+	/* On loss of the CIS the ASE shall autonomously transition to QoS
+	 * Configured and notify the peer.
+	 */
+	if (stream->ep->state == BT_ASCS_ASE_STATE_STREAMING ||
+			stream->ep->state == BT_ASCS_ASE_STATE_ENABLING ||
+			stream->ep->state == BT_ASCS_ASE_STATE_DISABLING)
+		stream_set_state(stream, BT_BAP_STREAM_STATE_QOS);
+
 	bt_bap_stream_set_io(stream, -1);
 	return false;
 }
-- 
2.43.0

Re: [PATCH BlueZ] shared/bap: Transition ASE to QoS Configured on CIS loss

[Pauli Virtanen]

ti, 2026-06-09 kello 23:11 +0200, Simon Mikuda kirjoitti:
> stream_io_disconnected() only handled the Releasing state, leaving
> Enabling, Streaming and Disabling ASEs stuck when the CIS was lost
> unexpectedly. The ASE shall autonomously move to QoS Configured on loss
> of the CIS and notify the peer; add that transition.
> 
> Fixes PTS test BAP/USR/SCC/BV-167-C
> ---
>  src/shared/bap.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/src/shared/bap.c b/src/shared/bap.c
> index deb85b264..350ed53d9 100644
> --- a/src/shared/bap.c
> +++ b/src/shared/bap.c
> @@ -6779,6 +6779,14 @@ static bool stream_io_disconnected(struct io *io, void *user_data)
>  	if (stream->ep->state == BT_ASCS_ASE_STATE_RELEASING)
>  		stream_set_state(stream, BT_BAP_STREAM_STATE_CONFIG);
>  
> +	/* On loss of the CIS the ASE shall autonomously transition to QoS
> +	 * Configured and notify the peer.
> +	 */
> +	if (stream->ep->state == BT_ASCS_ASE_STATE_STREAMING ||
> +			stream->ep->state == BT_ASCS_ASE_STATE_ENABLING ||
> +			stream->ep->state == BT_ASCS_ASE_STATE_DISABLING)
> +		stream_set_state(stream, BT_BAP_STREAM_STATE_QOS);
> +
>  	bt_bap_stream_set_io(stream, -1);
>  	return false;
>  }

iirc it may be also broadcast source here, does it do the right thing?

-- 
Pauli Virtanen

RE: [BlueZ] shared/bap: Transition ASE to QoS Configured on CIS loss

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1600 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1108825

---Test result---

Test Summary:
CheckPatch                    PASS      0.45 seconds
GitLint                       PASS      0.48 seconds
BuildEll                      PASS      20.19 seconds
BluezMake                     PASS      625.65 seconds
MakeCheck                     PASS      12.74 seconds
MakeDistcheck                 PASS      236.69 seconds
CheckValgrind                 PASS      257.53 seconds
CheckSmatch                   WARNING   326.14 seconds
bluezmakeextell               PASS      165.85 seconds
IncrementalBuild              PASS      622.35 seconds
ScanBuild                     PASS      935.06 seconds

Details
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
src/shared/bap.c:317:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:317:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:317:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structures


https://github.com/bluez/bluez/pull/2209

---
Regards,
Linux Bluetooth