Linux bluetooth development
 help / color / mirror / Atom feed
* [PATCH] Bluetooth: fix BT dependency for submodules
@ 2026-07-20 15:09 Iva Kasprzaková
  2026-07-20 16:48 ` bluez.test.bot
  2026-07-20 19:50 ` [PATCH] " Luiz Augusto von Dentz
  0 siblings, 2 replies; 3+ messages in thread
From: Iva Kasprzaková @ 2026-07-20 15:09 UTC (permalink / raw)
  To: marcel, luiz.dentz, linux-bluetooth
  Cc: xrabek1, xkasprz, Iva Kasprzaková

Rfcomm (BT_RFCOMM), bnep (BT_BNEP), and hidp (BT_HIDP) modules are
dependent on the bluetooth module (BT, tristate) only transitively
through the boolean BT_BREDR. Therefore, the modules can be selected as
built-in even if the BT=m. The combination of BT=m and =y for the said
modules leads to the kernel build system silently ignoring those
modules, without ever compiling them as built-in or as loadable modules.

Add BT as a direct dependency to Kconfig of rfcomm, bnep and hidp. The
modules set to =y when BT=m will default to =m, rather then getting
silently ignored by the build system.

Signed-off-by: Iva Kasprzaková <iva@yenya.net>
---
 net/bluetooth/bnep/Kconfig   | 2 +-
 net/bluetooth/hidp/Kconfig   | 2 +-
 net/bluetooth/rfcomm/Kconfig | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/bluetooth/bnep/Kconfig b/net/bluetooth/bnep/Kconfig
index aac02b5b0d17..f8087e2d2c00 100644
--- a/net/bluetooth/bnep/Kconfig
+++ b/net/bluetooth/bnep/Kconfig
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config BT_BNEP
 	tristate "BNEP protocol support"
-	depends on BT_BREDR
+	depends on BT && BT_BREDR
 	select CRC32
 	help
 	  BNEP (Bluetooth Network Encapsulation Protocol) is Ethernet
diff --git a/net/bluetooth/hidp/Kconfig b/net/bluetooth/hidp/Kconfig
index e08aae35351a..ba52c7296f18 100644
--- a/net/bluetooth/hidp/Kconfig
+++ b/net/bluetooth/hidp/Kconfig
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config BT_HIDP
 	tristate "HIDP protocol support"
-	depends on BT_BREDR && HID
+	depends on BT && BT_BREDR && HID
 	help
 	  HIDP (Human Interface Device Protocol) is a transport layer
 	  for HID reports.  HIDP is required for the Bluetooth Human
diff --git a/net/bluetooth/rfcomm/Kconfig b/net/bluetooth/rfcomm/Kconfig
index 9b9953ebf4c0..e7af2d565cea 100644
--- a/net/bluetooth/rfcomm/Kconfig
+++ b/net/bluetooth/rfcomm/Kconfig
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config BT_RFCOMM
 	tristate "RFCOMM protocol support"
-	depends on BT_BREDR
+	depends on BT && BT_BREDR
 	help
 	  RFCOMM provides connection oriented stream transport.  RFCOMM
 	  support is required for Dialup Networking, OBEX and other Bluetooth

base-commit: c1cec2bbbeb5922d42d28c6af1707c4f3f8647e3
-- 
2.55.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: Bluetooth: fix BT dependency for submodules
  2026-07-20 15:09 [PATCH] Bluetooth: fix BT dependency for submodules Iva Kasprzaková
@ 2026-07-20 16:48 ` bluez.test.bot
  2026-07-20 19:50 ` [PATCH] " Luiz Augusto von Dentz
  1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2026-07-20 16:48 UTC (permalink / raw)
  To: linux-bluetooth, iva

[-- Attachment #1: Type: text/plain, Size: 2389 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1130992

---Test result---

Test Summary:
CheckPatch                    PASS      0.95 seconds
VerifyFixes                   PASS      0.08 seconds
VerifySignedoff               PASS      0.08 seconds
GitLint                       PASS      0.22 seconds
SubjectPrefix                 PASS      0.07 seconds
BuildKernel                   PASS      27.63 seconds
CheckAllWarning               PASS      30.42 seconds
CheckSparse                   PASS      29.04 seconds
BuildKernel32                 PASS      35.21 seconds
CheckKernelLLVM               SKIP      0.00 seconds
TestRunnerSetup               PASS      512.13 seconds
TestRunner_l2cap-tester       PASS      60.63 seconds
TestRunner_iso-tester         PASS      89.18 seconds
TestRunner_bnep-tester        PASS      19.06 seconds
TestRunner_mgmt-tester        FAIL      213.64 seconds
TestRunner_rfcomm-tester      PASS      25.85 seconds
TestRunner_sco-tester         PASS      31.82 seconds
TestRunner_ioctl-tester       PASS      26.32 seconds
TestRunner_mesh-tester        FAIL      26.18 seconds
TestRunner_smp-tester         PASS      24.30 seconds
TestRunner_userchan-tester    PASS      20.34 seconds
TestRunner_6lowpan-tester     PASS      23.37 seconds
IncrementalBuild              PASS      26.15 seconds

Details
##############################
Test: CheckKernelLLVM - SKIP
Desc: Build kernel with LLVM + context analysis
Output:
Clang not found
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 494, Passed: 489 (99.0%), Failed: 1, Not Run: 4

Failed Test Cases
Read Exp Feature - Success                           Failed       0.250 seconds
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0

Failed Test Cases
Mesh - Send cancel - 1                               Timed out    2.216 seconds
Mesh - Send cancel - 2                               Timed out    1.992 seconds


https://github.com/bluez/bluetooth-next/pull/463

---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Bluetooth: fix BT dependency for submodules
  2026-07-20 15:09 [PATCH] Bluetooth: fix BT dependency for submodules Iva Kasprzaková
  2026-07-20 16:48 ` bluez.test.bot
@ 2026-07-20 19:50 ` Luiz Augusto von Dentz
  1 sibling, 0 replies; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2026-07-20 19:50 UTC (permalink / raw)
  To: Iva Kasprzaková; +Cc: marcel, linux-bluetooth, xrabek1, xkasprz

Hi Iva,

On Mon, Jul 20, 2026 at 11:09 AM Iva Kasprzaková <iva@yenya.net> wrote:
>
> Rfcomm (BT_RFCOMM), bnep (BT_BNEP), and hidp (BT_HIDP) modules are
> dependent on the bluetooth module (BT, tristate) only transitively
> through the boolean BT_BREDR. Therefore, the modules can be selected as
> built-in even if the BT=m. The combination of BT=m and =y for the said
> modules leads to the kernel build system silently ignoring those
> modules, without ever compiling them as built-in or as loadable modules.
>
> Add BT as a direct dependency to Kconfig of rfcomm, bnep and hidp. The
> modules set to =y when BT=m will default to =m, rather then getting
> silently ignored by the build system.
>
> Signed-off-by: Iva Kasprzaková <iva@yenya.net>
> ---
>  net/bluetooth/bnep/Kconfig   | 2 +-
>  net/bluetooth/hidp/Kconfig   | 2 +-
>  net/bluetooth/rfcomm/Kconfig | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/bluetooth/bnep/Kconfig b/net/bluetooth/bnep/Kconfig
> index aac02b5b0d17..f8087e2d2c00 100644
> --- a/net/bluetooth/bnep/Kconfig
> +++ b/net/bluetooth/bnep/Kconfig
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  config BT_BNEP
>         tristate "BNEP protocol support"
> -       depends on BT_BREDR
> +       depends on BT && BT_BREDR
>         select CRC32
>         help
>           BNEP (Bluetooth Network Encapsulation Protocol) is Ethernet
> diff --git a/net/bluetooth/hidp/Kconfig b/net/bluetooth/hidp/Kconfig
> index e08aae35351a..ba52c7296f18 100644
> --- a/net/bluetooth/hidp/Kconfig
> +++ b/net/bluetooth/hidp/Kconfig
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  config BT_HIDP
>         tristate "HIDP protocol support"
> -       depends on BT_BREDR && HID
> +       depends on BT && BT_BREDR && HID
>         help
>           HIDP (Human Interface Device Protocol) is a transport layer
>           for HID reports.  HIDP is required for the Bluetooth Human
> diff --git a/net/bluetooth/rfcomm/Kconfig b/net/bluetooth/rfcomm/Kconfig
> index 9b9953ebf4c0..e7af2d565cea 100644
> --- a/net/bluetooth/rfcomm/Kconfig
> +++ b/net/bluetooth/rfcomm/Kconfig
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  config BT_RFCOMM
>         tristate "RFCOMM protocol support"
> -       depends on BT_BREDR
> +       depends on BT && BT_BREDR
>         help
>           RFCOMM provides connection oriented stream transport.  RFCOMM
>           support is required for Dialup Networking, OBEX and other Bluetooth
>
> base-commit: c1cec2bbbeb5922d42d28c6af1707c4f3f8647e3
> --
> 2.55.0

Looks like BT_6LOWPAN could also use the same logic:

https://sashiko.dev/#/patchset/20260720150919.9602-1-iva%40yenya.net

-- 
Luiz Augusto von Dentz

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-07-20 19:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-20 15:09 [PATCH] Bluetooth: fix BT dependency for submodules Iva Kasprzaková
2026-07-20 16:48 ` bluez.test.bot
2026-07-20 19:50 ` [PATCH] " Luiz Augusto von Dentz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox