[PATCH v1] Bluetooth: hci_sync: Fix not setting CE length on LE Set Default Rate

[PATCH v1] Bluetooth: hci_sync: Fix not setting CE length on LE Set Default Rate

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

hci_le_set_def_rate_sync() left min_ce_len and max_ce_len zeroed by the
memset, but the connection event length recommended in requests by a
Peripheral has a valid range of 0x0001 to 0x7CFF (Time = N * 125 us,
Time Range: 0.125 ms to 3.999875 s), so 0x0000 is invalid.

Set both to the minimum valid value.

Fixes: 2f8784cfe8a9 ("Bluetooth: Add support for Shorter Connection Interval (SCI) feature")
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
---
 net/bluetooth/hci_sync.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index 24eeb76f7207..334e5ebb26ee 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -4797,6 +4797,13 @@ static int hci_le_set_def_rate_sync(struct hci_dev *hdev)
 	cp.cont_num = cpu_to_le16(0x0001);
 	cp.supv_timeout = cpu_to_le16(0x000c);	/* 120 ms */
 
+	/* The connection event length recommended in requests by a Peripheral
+	 * uses units of 125 us with a valid range of 0x0001 to 0x7CFF
+	 * (0.125 ms to 3.999875 s), so use the minimum as the default.
+	 */
+	cp.min_ce_len = cpu_to_le16(0x0001);
+	cp.max_ce_len = cpu_to_le16(0x0001);
+
 	return __hci_cmd_sync_status(hdev, HCI_OP_LE_SET_DEF_RATE,
 				     sizeof(cp), &cp, HCI_CMD_TIMEOUT);
 }
-- 
2.54.0

RE: [v1] Bluetooth: hci_sync: Fix not setting CE length on LE Set Default Rate

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 2390 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1156273

---Test result---

Test Summary:
CheckPatch                    PASS      0.60 seconds
VerifyFixes                   PASS      2.17 seconds
VerifySignedoff               PASS      0.33 seconds
GitLint                       PASS      0.28 seconds
SubjectPrefix                 PASS      0.10 seconds
BuildKernel                   PASS      23.30 seconds
CheckAllWarning               PASS      26.00 seconds
CheckSparse                   PASS      31.60 seconds
BuildKernel32                 PASS      22.63 seconds
CheckKernelLLVM               SKIP      0.00 seconds
TestRunnerSetup               PASS      417.50 seconds
TestRunner_l2cap-tester       PASS      63.26 seconds
TestRunner_iso-tester         PASS      106.11 seconds
TestRunner_bnep-tester        PASS      17.09 seconds
TestRunner_mgmt-tester        FAIL      215.30 seconds
TestRunner_rfcomm-tester      PASS      23.93 seconds
TestRunner_sco-tester         PASS      29.87 seconds
TestRunner_ioctl-tester       PASS      24.74 seconds
TestRunner_mesh-tester        FAIL      24.78 seconds
TestRunner_smp-tester         PASS      21.53 seconds
TestRunner_userchan-tester    PASS      18.38 seconds
TestRunner_6lowpan-tester     PASS      21.62 seconds
IncrementalBuild              PASS      21.09 seconds

Details
##############################
Test: CheckKernelLLVM - SKIP
Desc: Build kernel with LLVM + context analysis
Output:
Clang not found
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 501, Passed: 496 (99.0%), Failed: 1, Not Run: 4

Failed Test Cases
Read Exp Feature - Success                           Failed       0.240 seconds
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0

Failed Test Cases
Mesh - Send cancel - 1                               Timed out    2.737 seconds
Mesh - Send cancel - 2                               Timed out    1.989 seconds


https://github.com/bluez/bluetooth-next/pull/689

---
Regards,
Linux Bluetooth