[PATCH] Bluetooth: mgmt: handle mesh send completion queue failure

[PATCH] Bluetooth: mgmt: handle mesh send completion queue failure

[Jiale Yao]

mesh_send_done() relies on the queued command and its destroy callback
to clear HCI_MESH_SENDING, complete the current transmission, and start
the next one. If hci_cmd_sync_queue() fails, neither callback runs and
mesh transmission remains permanently marked busy.

Run the completion and continuation callbacks directly when the command
cannot be queued.

Fixes: b338d91703fa ("Bluetooth: Implement support for Mesh")
Signed-off-by: Jiale Yao <yaojiale02@163.com>
---
 net/bluetooth/mgmt.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index ac4864e56ec7..690af594ddf4 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -1131,11 +1131,16 @@ static void mesh_send_done(struct work_struct *work)
 {
 	struct hci_dev *hdev = container_of(work, struct hci_dev,
 					    mesh_send_done.work);
+	int err;
 
 	if (!hci_dev_test_flag(hdev, HCI_MESH_SENDING))
 		return;
 
-	hci_cmd_sync_queue(hdev, mesh_send_done_sync, NULL, mesh_next);
+	err = hci_cmd_sync_queue(hdev, mesh_send_done_sync, NULL, mesh_next);
+	if (err < 0) {
+		mesh_send_done_sync(hdev, NULL);
+		mesh_next(hdev, NULL, err);
+	}
 }
 
 static void mgmt_init_hdev(struct sock *sk, struct hci_dev *hdev)
-- 
2.34.1

RE: Bluetooth: mgmt: handle mesh send completion queue failure

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1479 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1178770/

---Test result---

Test Summary:
CheckPatch                    PASS      0.61 seconds
VerifyFixes                   PASS      0.08 seconds
VerifySignedoff               PASS      0.08 seconds
GitLint                       PASS      0.23 seconds
SubjectPrefix                 PASS      0.07 seconds
BuildKernel                   PASS      29.56 seconds
CheckAllWarning               PASS      33.30 seconds
CheckSparse                   PASS      36.28 seconds
BuildKernel32                 PASS      29.98 seconds
CheckKernelLLVM               PASS      35.50 seconds
TestRunnerSetup               PASS      808.94 seconds
TestRunner_mgmt-tester        PASS      61.27 seconds
TestRunner_mesh-tester        FAIL      7.79 seconds
IncrementalBuild              PASS      27.07 seconds

Details
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0

Failed Test Cases
Mesh - Send cancel - 1                               Timed out    2.424 seconds
Mesh - Send cancel - 2                               Timed out    1.999 seconds


https://github.com/bluez/bluetooth-next/pull/854

---
Regards,
Linux Bluetooth