* [PATCH BlueZ] a2dp: Remove duplicate check in transport_cb
@ 2026-10-18 4:39 Iaroslav Voitovych
2026-10-18 7:27 ` [BlueZ] " bluez.test.bot
0 siblings, 1 reply; 2+ messages in thread
From: Iaroslav Voitovych @ 2026-10-18 4:39 UTC (permalink / raw)
To: linux-bluetooth
transport_cb() checks setup->stream twice in a row: commit
0bed9886cff3 ("a2dp: Fix crash on NULL stream in transport_cb") and
commit d84171e6cd68 ("a2dp: Fix crash on NULL stream in transport_cb")
add the same check. Remove the second copy.
---
profiles/audio/a2dp.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/profiles/audio/a2dp.c b/profiles/audio/a2dp.c
index 37f6d4ae1..cb1b3a980 100644
--- a/profiles/audio/a2dp.c
+++ b/profiles/audio/a2dp.c
@@ -2749,11 +2749,6 @@ static void transport_cb(GIOChannel *io, GError *err, gpointer user_data)
goto drop;
}
- if (!setup->stream) {
- error("bt_io_accept: setup %p has no stream", setup);
- goto drop;
- }
-
if (!avdtp_stream_set_transport(setup->stream,
g_io_channel_unix_get_fd(io),
imtu, omtu))
base-commit: fa6ba55020dee3c3183041c854c347b4582448be
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [BlueZ] a2dp: Remove duplicate check in transport_cb
2026-10-18 4:39 [PATCH BlueZ] a2dp: Remove duplicate check in transport_cb Iaroslav Voitovych
@ 2026-10-18 7:27 ` bluez.test.bot
0 siblings, 0 replies; 2+ messages in thread
From: bluez.test.bot @ 2026-10-18 7:27 UTC (permalink / raw)
To: linux-bluetooth, yaroslav.voytovych
[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1188165/
---Test result---
Test Summary:
CheckPatch PASS 0.46 seconds
GitLint PASS 0.34 seconds
BuildEll PASS 19.80 seconds
BluezMake PASS 300.65 seconds
MakeCheck PASS 3.29 seconds
MakeDistcheck PASS 143.30 seconds
CheckValgrind PASS 156.29 seconds
CheckSmatch PASS 296.27 seconds
bluezmakeextell PASS 95.84 seconds
TestFunctional PASS 1115.66 seconds
IncrementalBuild PASS 297.07 seconds
ScanBuild PASS 1124.20 seconds
https://github.com/bluez/bluez/pull/2689
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-18 7:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-18 4:39 [PATCH BlueZ] a2dp: Remove duplicate check in transport_cb Iaroslav Voitovych
2026-10-18 7:27 ` [BlueZ] " bluez.test.bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox