* [PATCH net-next] Bluetooth: btusb: disable by default Qualcomm multi-subsystem
@ 2026-10-22 15:38 Paolo Abeni
2026-10-22 15:44 ` Jakub Kicinski
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Paolo Abeni @ 2026-10-22 15:38 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: Luiz Augusto von Dentz, linux-bluetooth, netdev
New knobs should default to 'n'. The mentioned one depends on
BT_HCIBTUSB, but the latter is enabled on most systems.
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---
this is a last minute fixlet to avoid breaking expectation for the
upcoming net-next PR. I'll merge it in a matter of minutes unless
someone scream very loudly very soon!
---
drivers/bluetooth/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index db0189ca3cbe..0dca5e43edc5 100644
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -96,13 +96,12 @@ config BT_HCIBTUSB_QCOM
select FW_LOADER
select GPIOLIB
select WANT_DEV_COREDUMP
- default y
+ default n
help
Enables various required support, such as configuration, firmware
download, and error recovery, for Qualcomm Bluetooth controllers.
Say Y here to compile support for Qualcomm protocol.
- If unsure, say Y.
config BT_HCIBTSDIO
tristate "HCI SDIO driver"
--
2.56.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH net-next] Bluetooth: btusb: disable by default Qualcomm multi-subsystem
2026-10-22 15:38 [PATCH net-next] Bluetooth: btusb: disable by default Qualcomm multi-subsystem Paolo Abeni
@ 2026-10-22 15:44 ` Jakub Kicinski
2026-10-22 15:44 ` Luiz Augusto von Dentz
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Jakub Kicinski @ 2026-10-22 15:44 UTC (permalink / raw)
To: Paolo Abeni
Cc: Marcel Holtmann, Luiz Augusto von Dentz, linux-bluetooth, netdev
On Thu, 22 Oct 2026 17:38:06 +0200 Paolo Abeni wrote:
> New knobs should default to 'n'. The mentioned one depends on
> BT_HCIBTUSB, but the latter is enabled on most systems.
FTR added by commit:
3669487308f8 (Bluetooth: btusb: Add support for Qualcomm multi-subsystem QCC2072, 2026-09-13)
drivers/bluetooth/Kconfig | 14 +
drivers/bluetooth/Makefile | 1 +
drivers/bluetooth/btusb_qcom.h | 99 +
drivers/bluetooth/btusb_main.c | 121 ++
drivers/bluetooth/btusb_qcom.c | 4557 ++++++++++++++++++++++++++++++++++++++++
5 files changed, 4792 insertions(+)
so this is clearly gating new code, by Linus law the Kconfig should
default to disabled.
Acked-by: Jakub Kicinski <kuba@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH net-next] Bluetooth: btusb: disable by default Qualcomm multi-subsystem
2026-10-22 15:38 [PATCH net-next] Bluetooth: btusb: disable by default Qualcomm multi-subsystem Paolo Abeni
2026-10-22 15:44 ` Jakub Kicinski
@ 2026-10-22 15:44 ` Luiz Augusto von Dentz
2026-10-22 16:19 ` Paolo Abeni
2026-10-23 5:09 ` Zijun Hu
2026-10-22 15:50 ` patchwork-bot+netdevbpf
2026-10-22 18:07 ` [net-next] " bluez.test.bot
3 siblings, 2 replies; 7+ messages in thread
From: Luiz Augusto von Dentz @ 2026-10-22 15:44 UTC (permalink / raw)
To: Paolo Abeni, Zijun Hu; +Cc: Marcel Holtmann, linux-bluetooth, netdev
Hi Paolo,
On Thu, Oct 22, 2026 at 11:38 AM Paolo Abeni <pabeni@redhat.com> wrote:
>
> New knobs should default to 'n'. The mentioned one depends on
> BT_HCIBTUSB, but the latter is enabled on most systems.
>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
> this is a last minute fixlet to avoid breaking expectation for the
> upcoming net-next PR. I'll merge it in a matter of minutes unless
> someone scream very loudly very soon!
> ---
> drivers/bluetooth/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
> index db0189ca3cbe..0dca5e43edc5 100644
> --- a/drivers/bluetooth/Kconfig
> +++ b/drivers/bluetooth/Kconfig
> @@ -96,13 +96,12 @@ config BT_HCIBTUSB_QCOM
> select FW_LOADER
> select GPIOLIB
> select WANT_DEV_COREDUMP
> - default y
> + default n
> help
> Enables various required support, such as configuration, firmware
> download, and error recovery, for Qualcomm Bluetooth controllers.
>
> Say Y here to compile support for Qualcomm protocol.
> - If unsure, say Y.
>
> config BT_HCIBTSDIO
> tristate "HCI SDIO driver"
> --
> 2.56.0
Reviewed-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
@Zijun Hu lets us know if you have any problem with it being default
n, perhaps it can be default y for a specific Qualcomm platform but
not in general.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net-next] Bluetooth: btusb: disable by default Qualcomm multi-subsystem
2026-10-22 15:44 ` Luiz Augusto von Dentz
@ 2026-10-22 16:19 ` Paolo Abeni
2026-10-23 5:09 ` Zijun Hu
1 sibling, 0 replies; 7+ messages in thread
From: Paolo Abeni @ 2026-10-22 16:19 UTC (permalink / raw)
To: Luiz Augusto von Dentz; +Cc: Marcel Holtmann, linux-bluetooth, netdev, Zijun Hu
On 10/22/26 17:44, Luiz Augusto von Dentz wrote:
> Hi Paolo,
>
> On Thu, Oct 22, 2026 at 11:38 AM Paolo Abeni <pabeni@redhat.com> wrote:
>>
>> New knobs should default to 'n'. The mentioned one depends on
>> BT_HCIBTUSB, but the latter is enabled on most systems.
>>
>> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
>> ---
>> this is a last minute fixlet to avoid breaking expectation for the
>> upcoming net-next PR. I'll merge it in a matter of minutes unless
>> someone scream very loudly very soon!
>> ---
>> drivers/bluetooth/Kconfig | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
>> index db0189ca3cbe..0dca5e43edc5 100644
>> --- a/drivers/bluetooth/Kconfig
>> +++ b/drivers/bluetooth/Kconfig
>> @@ -96,13 +96,12 @@ config BT_HCIBTUSB_QCOM
>> select FW_LOADER
>> select GPIOLIB
>> select WANT_DEV_COREDUMP
>> - default y
>> + default n
>> help
>> Enables various required support, such as configuration, firmware
>> download, and error recovery, for Qualcomm Bluetooth controllers.
>>
>> Say Y here to compile support for Qualcomm protocol.
>> - If unsure, say Y.
>>
>> config BT_HCIBTSDIO
>> tristate "HCI SDIO driver"
>> --
>> 2.56.0
>
> Reviewed-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Thank you _a lot_ for the very prompt reply. Really appreciated and
really useful!
+1 on my beer-o-matic :)
/P
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net-next] Bluetooth: btusb: disable by default Qualcomm multi-subsystem
2026-10-22 15:44 ` Luiz Augusto von Dentz
2026-10-22 16:19 ` Paolo Abeni
@ 2026-10-23 5:09 ` Zijun Hu
1 sibling, 0 replies; 7+ messages in thread
From: Zijun Hu @ 2026-10-23 5:09 UTC (permalink / raw)
To: Luiz Augusto von Dentz, Paolo Abeni
Cc: Marcel Holtmann, linux-bluetooth, netdev
On 10/22/2026 11:44 PM, Luiz Augusto von Dentz wrote:
> @Zijun Hu lets us know if you have any problem with it being default
> n, perhaps it can be default y for a specific Qualcomm platform but
> not in general.
Hi Luiz,Paolo,Jakub
Default to y for the following reasons:
1) Avoid regressions when moving support for many existing Qualcomm controllers from btusb_main.c to btusb_qcom.c
2) Align with BT_HCIBTUSB_BCM and BT_HCIBTUSB_RTL, which also default to y.
3) USB devices are hotpluggable
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net-next] Bluetooth: btusb: disable by default Qualcomm multi-subsystem
2026-10-22 15:38 [PATCH net-next] Bluetooth: btusb: disable by default Qualcomm multi-subsystem Paolo Abeni
2026-10-22 15:44 ` Jakub Kicinski
2026-10-22 15:44 ` Luiz Augusto von Dentz
@ 2026-10-22 15:50 ` patchwork-bot+netdevbpf
2026-10-22 18:07 ` [net-next] " bluez.test.bot
3 siblings, 0 replies; 7+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-10-22 15:50 UTC (permalink / raw)
To: Paolo Abeni; +Cc: marcel, luiz.dentz, linux-bluetooth, netdev
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Thu, 22 Oct 2026 17:38:06 +0200 you wrote:
> New knobs should default to 'n'. The mentioned one depends on
> BT_HCIBTUSB, but the latter is enabled on most systems.
>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
> this is a last minute fixlet to avoid breaking expectation for the
> upcoming net-next PR. I'll merge it in a matter of minutes unless
> someone scream very loudly very soon!
>
> [...]
Here is the summary with links:
- [net-next] Bluetooth: btusb: disable by default Qualcomm multi-subsystem
https://git.kernel.org/netdev/net-next/c/1a2c35c49cc7
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [net-next] Bluetooth: btusb: disable by default Qualcomm multi-subsystem
2026-10-22 15:38 [PATCH net-next] Bluetooth: btusb: disable by default Qualcomm multi-subsystem Paolo Abeni
` (2 preceding siblings ...)
2026-10-22 15:50 ` patchwork-bot+netdevbpf
@ 2026-10-22 18:07 ` bluez.test.bot
3 siblings, 0 replies; 7+ messages in thread
From: bluez.test.bot @ 2026-10-22 18:07 UTC (permalink / raw)
To: linux-bluetooth, pabeni
[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1191408/
---Test result---
Test Summary:
CheckPatch PASS 1.26 seconds
VerifyFixes PASS 0.11 seconds
VerifySignedoff PASS 0.11 seconds
GitLint PASS 0.26 seconds
SubjectPrefix PASS 0.85 seconds
BuildKernel PASS 19.12 seconds
CheckAllWarning PASS 21.87 seconds
CheckSparse PASS 24.11 seconds
BuildKernel32 PASS 21.62 seconds
CheckKernelLLVM PASS 21.40 seconds
TestRunnerSetup PASS 443.05 seconds
IncrementalBuild PASS 18.70 seconds
https://github.com/bluez/bluetooth-next/pull/982
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-10-23 5:09 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-22 15:38 [PATCH net-next] Bluetooth: btusb: disable by default Qualcomm multi-subsystem Paolo Abeni
2026-10-22 15:44 ` Jakub Kicinski
2026-10-22 15:44 ` Luiz Augusto von Dentz
2026-10-22 16:19 ` Paolo Abeni
2026-10-23 5:09 ` Zijun Hu
2026-10-22 15:50 ` patchwork-bot+netdevbpf
2026-10-22 18:07 ` [net-next] " bluez.test.bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox