[PATCH BlueZ] obexd: Improve handling unsupported MAP events

[PATCH BlueZ] obexd: Improve handling unsupported MAP events

[Mohammed Sadiq]

As per the spec, unsupported events should be ignored. But since bluez
used to notify all unsupported events over DBus, removing support for
those will break DBus API and clients that may be depending on them.

But all unsupported events are being notified by replacing the
original message object, as all map event types defaults to
MAP_ET_NEW_MESSAGE if unsupported - As the event struct is allocated
with g_new0().

So change the first member in event enum to MAP_ET_UNSUPPORTED so that
it'll be the default on allocation and notify over DBus on unsupported
events.
---
 obexd/client/map-event.h | 1 +
 obexd/client/map.c       | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/obexd/client/map-event.h b/obexd/client/map-event.h
index ab185eadf..740c08be2 100644
--- a/obexd/client/map-event.h
+++ b/obexd/client/map-event.h
@@ -11,6 +11,7 @@
 struct obc_session;
 
 enum map_event_type {
+	MAP_ET_UNSUPPORTED,
 	MAP_ET_NEW_MESSAGE,
 	MAP_ET_DELIVERY_SUCCESS,
 	MAP_ET_SENDING_SUCCESS,
diff --git a/obexd/client/map.c b/obexd/client/map.c
index 487354252..6702aa333 100644
--- a/obexd/client/map.c
+++ b/obexd/client/map.c
@@ -2126,6 +2126,9 @@ static void map_handle_notification(struct map_event *event, void *user_data)
 		event->msg_type);
 
 	switch (event->type) {
+	case MAP_ET_UNSUPPORTED:
+		map_handle_status_changed(map, event, "notification");
+		break;
 	case MAP_ET_NEW_MESSAGE:
 		map_handle_new_message(map, event);
 		map_handle_status_changed(map, event, "notification");
-- 
2.47.3

RE: [BlueZ] obexd: Improve handling unsupported MAP events

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 857 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1192650/

---Test result---

Test Summary:
CheckPatch                    PASS      0.28 seconds
GitLint                       PASS      0.22 seconds
BuildEll                      PASS      17.63 seconds
BluezMake                     PASS      254.05 seconds
CheckSmatch                   PASS      227.38 seconds
bluezmakeextell               PASS      84.52 seconds
TestFunctional                PASS      1012.77 seconds
IncrementalBuild              PASS      257.62 seconds
ScanBuild                     PASS      922.53 seconds



https://github.com/bluez/bluez/pull/2709

---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ] obexd: Improve handling unsupported MAP events

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Sat, 24 Oct 2026 17:27:34 +0530 you wrote:
> As per the spec, unsupported events should be ignored. But since bluez
> used to notify all unsupported events over DBus, removing support for
> those will break DBus API and clients that may be depending on them.
> 
> But all unsupported events are being notified by replacing the
> original message object, as all map event types defaults to
> MAP_ET_NEW_MESSAGE if unsupported - As the event struct is allocated
> with g_new0().
> 
> [...]

Here is the summary with links:
  - [BlueZ] obexd: Improve handling unsupported MAP events
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=8a1b156eda8a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html