[PATCH BlueZ] monitor: Fix Conn Interval rsp group decode

[PATCH BlueZ] monitor: Fix Conn Interval rsp group decode

[Pauli Virtanen]

util_iov_pull() returns the advanced base, not the bytes pulled, so
each connection interval group was decoded six bytes past its actual
position. Use util_iov_pull_mem() instead.

Fixes: 79cfd07224ff ("monitor: Add decoding for Short Connection Interval feature")
Assisted-by: opencode:qwen3.8-flash-next
---
 monitor/packet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor/packet.c b/monitor/packet.c
index 8a0e49ff4..fdc02fe01 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -10289,7 +10289,7 @@ static void le_read_conn_interval_rsp(uint16_t index, const void *data,
 	for (i = 0; i < rsp->num_grps; i++) {
 		const struct bt_hci_le_conn_interval_group *grp;
 
-		grp = util_iov_pull(&iov, sizeof(*grp));
+		grp = util_iov_pull_mem(&iov, sizeof(*grp));
 		if (!grp) {
 			print_text(COLOR_ERROR, "  invalid group");
 			break;
-- 
2.56.0

RE: [BlueZ] monitor: Fix Conn Interval rsp group decode

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1353 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1197782/

---Test result---

Test Summary:
CheckPatch                    PASS      0.34 seconds
GitLint                       PASS      0.23 seconds
BuildEll                      PASS      16.16 seconds
BluezMake                     PASS      223.97 seconds
MakeCheck                     PASS      0.78 seconds
MakeDistcheck                 PASS      115.82 seconds
CheckValgrind                 PASS      114.18 seconds
CheckSmatch                   WARNING   219.03 seconds
bluezmakeextell               PASS      74.34 seconds
TestFunctional                PASS      935.71 seconds
IncrementalBuild              PASS      226.46 seconds
ScanBuild                     PASS      806.57 seconds

Details
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
monitor/packet.c:2289:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3925:52: warning: array of flexible structuresmonitor/bt.h:3913:40: warning: array of flexible structures


https://github.com/bluez/bluez/pull/2741

---
Regards,
Linux Bluetooth