[PATCH v1] Bluetooth: btintel_pcie: Fix SCP DBGC base address

[PATCH v1] Bluetooth: btintel_pcie: Fix SCP DBGC base address

[Chandrashekar Devegowda]

BTINTEL_PCIE_DBGC_BASE_ADDR_SCP is defined as 0xf0d5d500, one register
row past the base of the SCP debug controller. The status and
wrap-around registers derived from it at offsets 0x1C and 0x2C
therefore point at the wrong addresses, and the debug buffer status
and wrap-around state read while dumping SCP debug traces are
incorrect.

Use 0xf0d5d400 so that the derived offsets land on the intended
registers.

Fixes: e43b33bf8d67 ("Bluetooth: btintel_pcie: Load IOSF debug regs by controller variant")
Signed-off-by: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>
---
 drivers/bluetooth/btintel_pcie.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btintel_pcie.h b/drivers/bluetooth/btintel_pcie.h
index f04dfb0b30fa..c11620dbec46 100644
--- a/drivers/bluetooth/btintel_pcie.h
+++ b/drivers/bluetooth/btintel_pcie.h
@@ -82,7 +82,7 @@
 #define BTINTEL_PCIE_DBGC_CUR_DBGBUFF_STATUS		(BTINTEL_PCIE_DBGC_BASE_ADDR + 0x1C)
 #define BTINTEL_PCIE_DBGC_DBGBUFF_WRAP_ARND		(BTINTEL_PCIE_DBGC_BASE_ADDR + 0x2C)
 
-#define BTINTEL_PCIE_DBGC_BASE_ADDR_SCP			(0xf0d5d500)
+#define BTINTEL_PCIE_DBGC_BASE_ADDR_SCP			(0xf0d5d400)
 #define BTINTEL_PCIE_DBGC_CUR_DBGBUFF_STATUS_SCP	(BTINTEL_PCIE_DBGC_BASE_ADDR_SCP + 0x1C)
 #define BTINTEL_PCIE_DBGC_DBGBUFF_WRAP_ARND_SCP		(BTINTEL_PCIE_DBGC_BASE_ADDR_SCP + 0x2C)
 #define BTINTEL_PCIE_DBGC_ALLOCATION_OFFSET		0x100
-- 
2.43.0

Re: [PATCH v1] Bluetooth: btintel_pcie: Fix SCP DBGC base address

[Paul Menzel]

[Cc: +Sai as the author of the fixed commit]

Dear Chandrashekar,


Thank you for your patch.

Am 04.11.26 um 07:45 schrieb Chandrashekar Devegowda:
> BTINTEL_PCIE_DBGC_BASE_ADDR_SCP is defined as 0xf0d5d500, one register
> row past the base of the SCP debug controller.

Please mention the source where to verify that? Was some typo in the 
datasheet corrected?

> The status and
> wrap-around registers derived from it at offsets 0x1C and 0x2C
> therefore point at the wrong addresses, and the debug buffer status
> and wrap-around state read while dumping SCP debug traces are
> incorrect.
> 
> Use 0xf0d5d400 so that the derived offsets land on the intended
> registers.

Please configure your editor to use the official line length limit of 75 
characters. That would save two lines here.

Please add a paragraph to how to test this.

> Fixes: e43b33bf8d67 ("Bluetooth: btintel_pcie: Load IOSF debug regs by controller variant")
> Signed-off-by: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>
> ---
>   drivers/bluetooth/btintel_pcie.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/btintel_pcie.h b/drivers/bluetooth/btintel_pcie.h
> index f04dfb0b30fa..c11620dbec46 100644
> --- a/drivers/bluetooth/btintel_pcie.h
> +++ b/drivers/bluetooth/btintel_pcie.h
> @@ -82,7 +82,7 @@
>   #define BTINTEL_PCIE_DBGC_CUR_DBGBUFF_STATUS		(BTINTEL_PCIE_DBGC_BASE_ADDR + 0x1C)
>   #define BTINTEL_PCIE_DBGC_DBGBUFF_WRAP_ARND		(BTINTEL_PCIE_DBGC_BASE_ADDR + 0x2C)
>   
> -#define BTINTEL_PCIE_DBGC_BASE_ADDR_SCP			(0xf0d5d500)
> +#define BTINTEL_PCIE_DBGC_BASE_ADDR_SCP			(0xf0d5d400)
>   #define BTINTEL_PCIE_DBGC_CUR_DBGBUFF_STATUS_SCP	(BTINTEL_PCIE_DBGC_BASE_ADDR_SCP + 0x1C)
>   #define BTINTEL_PCIE_DBGC_DBGBUFF_WRAP_ARND_SCP		(BTINTEL_PCIE_DBGC_BASE_ADDR_SCP + 0x2C)
>   #define BTINTEL_PCIE_DBGC_ALLOCATION_OFFSET		0x100


Kind regards,

Paul

RE: [v1] Bluetooth: btintel_pcie: Fix SCP DBGC base address

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1201364/

---Test result---

Test Summary:
CheckPatch                    PASS      0.38 seconds
VerifyFixes                   PASS      0.05 seconds
VerifySignedoff               PASS      0.05 seconds
GitLint                       PASS      0.15 seconds
SubjectPrefix                 PASS      0.05 seconds
BuildKernel                   PASS      20.39 seconds
CheckAllWarning               PASS      23.01 seconds
CheckSparse                   PASS      24.60 seconds
BuildKernel32                 PASS      20.47 seconds
CheckKernelLLVM               PASS      22.36 seconds
TestRunnerSetup               PASS      475.52 seconds
IncrementalBuild              PASS      18.85 seconds



https://github.com/bluez/bluetooth-next/pull/1060

---
Regards,
Linux Bluetooth