[PATCH] Bluetooth: MGMT: Fix runtime config status opcode

[PATCH] Bluetooth: MGMT: Fix runtime config status opcode

[raoxu]

From: Xu Rao <raoxu@uniontech.com>

The Set Default Runtime Configuration command uses opcode 0x004e,
but set_def_runtime_config() reports its invalid-parameter status with
the Set Default System Configuration opcode, 0x004c.

A management client that matches Command Status events to its pending
request by opcode therefore cannot associate the response with the
request it sent. Runtime configuration parameters are not implemented,
so the command still returns MGMT_STATUS_INVALID_PARAMS.

Use MGMT_OP_SET_DEF_RUNTIME_CONFIG for the status event so the response
identifies the command that was actually handled.

Fixes: aececa645dc7 ("Bluetooth: mgmt: Add commands for runtime configuration")
Signed-off-by: Xu Rao <raoxu@uniontech.com>
Cc: stable@vger.kernel.org
---
 net/bluetooth/mgmt_config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/mgmt_config.c b/net/bluetooth/mgmt_config.c
index fdcc752c6f13..6a617656bfbe 100644
--- a/net/bluetooth/mgmt_config.c
+++ b/net/bluetooth/mgmt_config.c
@@ -362,6 +362,6 @@ int set_def_runtime_config(struct sock *sk, struct hci_dev *hdev, void *data,
 {
 	bt_dev_dbg(hdev, "sock %p", sk);

-	return mgmt_cmd_status(sk, hdev->id, MGMT_OP_SET_DEF_SYSTEM_CONFIG,
+	return mgmt_cmd_status(sk, hdev->id, MGMT_OP_SET_DEF_RUNTIME_CONFIG,
 			       MGMT_STATUS_INVALID_PARAMS);
 }
--
2.50.1

RE: Bluetooth: MGMT: Fix runtime config status opcode

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1206644/

---Test result---

Test Summary:
CheckPatch                    PASS      0.69 seconds
VerifyFixes                   PASS      0.13 seconds
VerifySignedoff               PASS      0.17 seconds
GitLint                       PASS      0.33 seconds
SubjectPrefix                 PASS      0.13 seconds
BuildKernel                   PASS      23.15 seconds
CheckAllWarning               PASS      26.40 seconds
CheckSparse                   PASS      28.51 seconds
BuildKernel32                 PASS      23.79 seconds
CheckKernelLLVM               PASS      25.05 seconds
TestRunnerSetup               PASS      594.49 seconds
TestRunner_mgmt-tester        PASS      84.87 seconds
TestRunner_mesh-tester        PASS      5.30 seconds
IncrementalBuild              PASS      23.81 seconds



https://github.com/bluez/bluetooth-next/pull/1096

---
Regards,
Linux Bluetooth