Linux bluetooth development
 help / color / mirror / Atom feed
* [PATCH v2] Bluetooth: btbcm: Add entries for BCM4364B3 UART Bluetooth
@ 2026-11-22 16:51 Jason Perlow
  2026-11-22 17:22 ` [v2] " bluez.test.bot
  0 siblings, 1 reply; 2+ messages in thread
From: Jason Perlow @ 2026-11-22 16:51 UTC (permalink / raw)
  To: Marcel Holtmann, Luiz Augusto von Dentz, linux-bluetooth
  Cc: linux-kernel, Paul Menzel

The BCM4364B3 combo chip on Apple T2 Macs, e.g. the MacBookPro16,1, has a
UART Bluetooth controller that reports LMP subversion 0x3032 (001.016.050)
on some units and 0x305b (001.016.091) on others.  Neither has an entry in
bcm_uart_subver_table, so the controller is logged without a name:

  Bluetooth: hci0: BCM4364B3 Trinidad Olympic GEN (MFG)
  Bluetooth: hci0: BCM (001.016.091) build 0115

and the firmware lookup only tries the generic "brcm/BCM.hcd".

Add both subversions so the controller is named and its firmware is looked
up as "brcm/BCM4364B3.hcd" first.  Tested on two MacBookPro16,1 with a
v7.4-rc3 based kernel carrying an equivalent change, one reporting 0x3032
and one reporting 0x305b.  They now log:

  Bluetooth: hci0: BCM4364B3 (001.016.050) build 0082
  Bluetooth: hci0: BCM4364B3 (001.016.091) build 0115

No functional change is claimed: the controller initialises without these
entries; they name it and make the firmware lookup try brcm/BCM4364B3.hcd
first.

Signed-off-by: Jason Perlow <jperlow@gmail.com>
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
Changes in v2:
- sort the new entries by subversion, between 0x2128 and 0x4119 (Paul Menzel)
- say in the commit message that no functional change is claimed (Paul Menzel)
- add Reviewed-by from Paul Menzel
 drivers/bluetooth/btbcm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
index 065536d4ec76..def0853fd8ea 100644
--- a/drivers/bluetooth/btbcm.c
+++ b/drivers/bluetooth/btbcm.c
@@ -518,6 +518,8 @@ static const struct bcm_subver_table bcm_uart_subver_table[] = {
 	{ 0x410c, "BCM43430B0"	},	/* 002.001.012 */
 	{ 0x2119, "BCM4373A0"	},	/* 001.001.025 */
 	{ 0x2128, "BCM4384A0"	},	/* 001.001.040 */
+	{ 0x3032, "BCM4364B3"	},	/* 001.016.050 */
+	{ 0x305b, "BCM4364B3"	},	/* 001.016.091 */
 	{ 0x4119, "BCM4384B0"	},	/* 002.001.025 */
 	{ }
 };
-- 
2.50.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [v2] Bluetooth: btbcm: Add entries for BCM4364B3 UART Bluetooth
  2026-11-22 16:51 [PATCH v2] Bluetooth: btbcm: Add entries for BCM4364B3 UART Bluetooth Jason Perlow
@ 2026-11-22 17:22 ` bluez.test.bot
  0 siblings, 0 replies; 2+ messages in thread
From: bluez.test.bot @ 2026-11-22 17:22 UTC (permalink / raw)
  To: linux-bluetooth, jperlow

[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/series/1218823/

---Test result---

Test Summary:
CheckPatch                    PASS      0.56 seconds
VerifyFixes                   PASS      0.11 seconds
VerifySignedoff               PASS      0.11 seconds
GitLint                       PASS      0.28 seconds
SubjectPrefix                 PASS      0.10 seconds
BuildKernel                   PASS      20.31 seconds
CheckAllWarning               PASS      23.98 seconds
CheckSparse                   PASS      25.46 seconds
BuildKernel32                 PASS      20.84 seconds
CheckKernelLLVM               PASS      21.14 seconds
TestRunnerSetup               PASS      492.41 seconds
IncrementalBuild              PASS      19.24 seconds



https://github.com/bluez/bluetooth-next/pull/1188

---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-22 17:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-22 16:51 [PATCH v2] Bluetooth: btbcm: Add entries for BCM4364B3 UART Bluetooth Jason Perlow
2026-11-22 17:22 ` [v2] " bluez.test.bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox