* [PATCH BlueZ] adapter: Fix discovery filter RSSI and Pathloss matching
@ 2026-11-22 10:41 Simon Mikuda
2026-11-22 18:27 ` [BlueZ] " bluez.test.bot
0 siblings, 1 reply; 2+ messages in thread
From: Simon Mikuda @ 2026-11-22 10:41 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Simon Mikuda
is_filter_match() takes a device as close enough if the RSSI threshold
is unset or met, or if the Pathloss threshold is unset or met. Since a
filter cannot set both, the one left unset lets every device through.
The Pathloss threshold, which the kernel cannot apply, is then never
applied at all, and an RSSI threshold only as far as the kernel filter
goes, which holds the lowest threshold of all clients.
To reproduce, discover a device with an RSSI of -60 dBm and a TX power
of 0 dBm, so a path loss of 60 dB, with a Pathloss filter of 59:
[bluetooth]# scan.transport bredr
[bluetooth]# scan.pathloss 59
[bluetooth]# scan on
The device is reported anyway:
parse_discovery_filter_dict() filtered discovery params:
transport: 1 rssi: 32767 pathloss: 59 ...
device_found_callback() hci0 addr 00:AA:01:01:00:42, rssi -60 ...
device_set_rssi_with_delta() rssi -60
device_set_tx_power() tx_power 0
Require each threshold that is set to be met.
Fixes: ebcb6aa7c527 ("core/adapter: Filter discovery results")
Assisted-by: Claude:claude-opus-5-5
---
src/adapter.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/adapter.c b/src/adapter.c
index 1439642cb..2f2832a8f 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -7610,11 +7610,11 @@ static bool is_filter_match(GSList *discovery_filter, struct eir_data *eir_data,
if (got_match) {
/* we have service match, check proximity */
- if (item->rssi == DISTANCE_VAL_INVALID ||
- item->rssi <= rssi ||
- item->pathloss == DISTANCE_VAL_INVALID ||
- (eir_data->tx_power != 127 &&
- eir_data->tx_power - rssi <= item->pathloss))
+ if ((item->rssi == DISTANCE_VAL_INVALID ||
+ item->rssi <= rssi) &&
+ (item->pathloss == DISTANCE_VAL_INVALID ||
+ (eir_data->tx_power != 127 &&
+ eir_data->tx_power - rssi <= item->pathloss)))
return true;
got_match = false;
base-commit: 1adfe662efeff12997df9ddd0960dbd0de9c8ea7
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-22 18:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-22 10:41 [PATCH BlueZ] adapter: Fix discovery filter RSSI and Pathloss matching Simon Mikuda
2026-11-22 18:27 ` [BlueZ] " bluez.test.bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox