* [PATCH BlueZ] avdtp: Fix error parsing from failed delay report request
@ 2026-11-22 10:38 Simon Mikuda
2026-11-22 18:39 ` [BlueZ] " bluez.test.bot
0 siblings, 1 reply; 2+ messages in thread
From: Simon Mikuda @ 2026-11-22 10:38 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Simon Mikuda
A Delay Report Reject carries only the Error Code, as the one
avdtp_delayreport_cmd() sends does, but avdtp_parse_rej() parsed it
with stream_rej_to_err(), which wants an ACP SEID before the Error
Code. The 1 byte reject failed its size check, avdtp_parse_rej()
returned FALSE, and session_cb() treated that as a broken signalling
channel: connection_lost() released every stream of the session and
A2DP disconnected, only because the remote refused a delay report.
A remote rejects one, for example, when it crosses a Close of the
stream (BAD_ACP_SEID or BAD_STATE), and bluetoothd sends one as a
sink as soon as a stream is configured.
Parse it with seid_rej_to_err(), which reads the Error Code alone.
Fixes: 5f8a274881a8 ("Add support for AVDTP 1.3 Delay Reporting")
Assisted-by: Claude:claude-opus-5-5
---
profiles/audio/avdtp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c
index 5ebc0c5cc..c49ac9c0e 100644
--- a/profiles/audio/avdtp.c
+++ b/profiles/audio/avdtp.c
@@ -3212,7 +3212,7 @@ static gboolean avdtp_parse_rej(struct avdtp *session,
sep->user_data);
return FALSE;
case AVDTP_DELAY_REPORT:
- if (!stream_rej_to_err(buf, size, &err, &acp_seid))
+ if (!seid_rej_to_err(buf, size, &err))
return FALSE;
error("DELAY_REPORT request rejected: %s (%d)",
avdtp_strerror(&err), err.err.error_code);
base-commit: 1adfe662efeff12997df9ddd0960dbd0de9c8ea7
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-22 18:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-22 10:38 [PATCH BlueZ] avdtp: Fix error parsing from failed delay report request Simon Mikuda
2026-11-22 18:39 ` [BlueZ] " bluez.test.bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox