From: Szymon Janc <szymon.janc@tieto.com>
To: Grzegorz Kolodziejczyk <grzegorz.kolodziejczyk@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] android/gatt: Change device information service handle number
Date: Thu, 29 Jan 2015 16:49:55 +0100 [thread overview]
Message-ID: <7691265.5utIoNFrWh@leonov> (raw)
In-Reply-To: <1421938912-17448-1-git-send-email-grzegorz.kolodziejczyk@tieto.com>
Hi Grzegorz,
On Thursday 22 of January 2015 16:01:51 Grzegorz Kolodziejczyk wrote:
> This patch corrects number of handles which are reserved for DIS service
> while adding to gatt db. Sufficient amount for all DIS characteristics
> instances is 17.
>
> This is related to PTS test case:
> TC_DEC_BV_09_C - while all characteristics are registered, 15 handles in
> service wasn't sufficient to register PNP ID.
> ---
> android/gatt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/android/gatt.c b/android/gatt.c
> index 1d65c2a..3b690f9 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -6898,7 +6898,7 @@ static void register_device_info_service(void)
>
> /* Device Information Service */
> bt_uuid16_create(&uuid, 0x180a);
> - service = gatt_db_add_service(gatt_db, &uuid, true, 15);
> + service = gatt_db_add_service(gatt_db, &uuid, true, 17);
>
> /* User data are not const hence (void *) cast is used */
> data = bt_config_get_name();
Both patches applied, thanks.
--
BR
Szymon Janc
prev parent reply other threads:[~2015-01-29 15:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 15:01 [PATCH 1/2] android/gatt: Change device information service handle number Grzegorz Kolodziejczyk
2015-01-22 15:01 ` [PATCH 2/2] android/pts: Update DIS PTS 6.0 pixits, pics, results for android 5.0 Grzegorz Kolodziejczyk
2015-01-29 15:49 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7691265.5utIoNFrWh@leonov \
--to=szymon.janc@tieto.com \
--cc=grzegorz.kolodziejczyk@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox