[PATCH 1/2] android/gatt: Change device information service handle number

[PATCH 1/2] android/gatt: Change device information service handle number

[Grzegorz Kolodziejczyk]

This patch corrects number of handles which are reserved for DIS service
while adding to gatt db. Sufficient amount for all DIS characteristics
instances is 17.

This is related to PTS test case:
TC_DEC_BV_09_C - while all characteristics are registered, 15 handles in
service wasn't sufficient to register PNP ID.
---
 android/gatt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/android/gatt.c b/android/gatt.c
index 1d65c2a..3b690f9 100644
--- a/android/gatt.c
+++ b/android/gatt.c
@@ -6898,7 +6898,7 @@ static void register_device_info_service(void)
 
 	/* Device Information Service */
 	bt_uuid16_create(&uuid, 0x180a);
-	service = gatt_db_add_service(gatt_db, &uuid, true, 15);
+	service = gatt_db_add_service(gatt_db, &uuid, true, 17);
 
 	/* User data are not const hence (void *) cast is used */
 	data = bt_config_get_name();
-- 
1.9.3

[PATCH 2/2] android/pts: Update DIS PTS 6.0 pixits, pics, results for android 5.0

[Grzegorz Kolodziejczyk]

This patch updates test pixits, pics, test case list with results for
DIS profile against android 5.0.
---
 android/pics-dis.txt  | 2 +-
 android/pixit-dis.txt | 3 ++-
 android/pts-dis.txt   | 4 ++--
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/android/pics-dis.txt b/android/pics-dis.txt
index 169173d..ed207c8 100644
--- a/android/pics-dis.txt
+++ b/android/pics-dis.txt
@@ -1,6 +1,6 @@
 DIS PICS for the PTS tool.
 
-PTS version: 5.3
+PTS version: 6.0
 
 * - different than PTS defaults
 
diff --git a/android/pixit-dis.txt b/android/pixit-dis.txt
index 71729fe..13fe78f 100644
--- a/android/pixit-dis.txt
+++ b/android/pixit-dis.txt
@@ -1,6 +1,6 @@
 DIS PIXIT for the PTS tool.
 
-PTS version: 5.3
+PTS version: 6.0
 
 * - different than PTS defaults
 & - should be set to IUT Bluetooth address
@@ -22,4 +22,5 @@ TSPX_delete_ltk						FALSE
 TSPX_security_enabled					TRUE (*)
 TSPX_iut_setup_att_over_br_edr				FALSE
 TSPX_tester_appearance					0000
+TSPX_iut_use_resolvable_random_address			FALSE
 -------------------------------------------------------------------------------
diff --git a/android/pts-dis.txt b/android/pts-dis.txt
index fb67687..857a149 100644
--- a/android/pts-dis.txt
+++ b/android/pts-dis.txt
@@ -1,7 +1,7 @@
 PTS test results for DIS
 
-PTS version: 5.3
-Tested: 26-November-2014
+PTS version: 6.0
+Tested: 22-January-2015
 Android version: 5.0
 
 Results:
-- 
1.9.3

Re: [PATCH 1/2] android/gatt: Change device information service handle number

[Szymon Janc]

Hi Grzegorz,

On Thursday 22 of January 2015 16:01:51 Grzegorz Kolodziejczyk wrote:
> This patch corrects number of handles which are reserved for DIS service
> while adding to gatt db. Sufficient amount for all DIS characteristics
> instances is 17.
> 
> This is related to PTS test case:
> TC_DEC_BV_09_C - while all characteristics are registered, 15 handles in
> service wasn't sufficient to register PNP ID.
> ---
>  android/gatt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/android/gatt.c b/android/gatt.c
> index 1d65c2a..3b690f9 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -6898,7 +6898,7 @@ static void register_device_info_service(void)
> 
>  	/* Device Information Service */
>  	bt_uuid16_create(&uuid, 0x180a);
> -	service = gatt_db_add_service(gatt_db, &uuid, true, 15);
> +	service = gatt_db_add_service(gatt_db, &uuid, true, 17);
> 
>  	/* User data are not const hence (void *) cast is used */
>  	data = bt_config_get_name();

Both patches applied, thanks.

-- 
BR
Szymon Janc