[PATCH] Bluetooth: hci_bcm: remove duplicated brcm,bcm4330-bt compatible

[PATCH] Bluetooth: hci_bcm: remove duplicated brcm,bcm4330-bt compatible

[Krzysztof Kozlowski]

brcm,bcm4330-bt is already on the list.

Fixes: 81534d4835de ("Bluetooth: btbcm: Add BCM4330 and BCM4334 compatibles")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 drivers/bluetooth/hci_bcm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
index ef54afa29357..7852abf15ddf 100644
--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -1508,7 +1508,6 @@ static const struct of_device_id bcm_bluetooth_of_match[] = {
 	{ .compatible = "brcm,bcm4330-bt" },
 	{ .compatible = "brcm,bcm4334-bt" },
 	{ .compatible = "brcm,bcm4345c5" },
-	{ .compatible = "brcm,bcm4330-bt" },
 	{ .compatible = "brcm,bcm43438-bt", .data = &bcm43438_device_data },
 	{ .compatible = "brcm,bcm43540-bt", .data = &bcm4354_device_data },
 	{ .compatible = "brcm,bcm4335a0" },
-- 
2.30.2

RE: Bluetooth: hci_bcm: remove duplicated brcm,bcm4330-bt compatible

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 3267 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=548291

---Test result---

Test Summary:
CheckPatch                    FAIL      0.44 seconds
GitLint                       PASS      0.10 seconds
BuildKernel                   PASS      519.20 seconds
TestRunner: Setup             PASS      345.93 seconds
TestRunner: l2cap-tester      PASS      2.70 seconds
TestRunner: bnep-tester       PASS      1.93 seconds
TestRunner: mgmt-tester       PASS      31.31 seconds
TestRunner: rfcomm-tester     PASS      2.09 seconds
TestRunner: sco-tester        PASS      2.12 seconds
TestRunner: smp-tester        PASS      2.16 seconds
TestRunner: userchan-tester   PASS      1.95 seconds

Details
##############################
Test: CheckPatch - FAIL - 0.44 seconds
Run checkpatch.pl script with rule in .checkpatch.conf
Bluetooth: hci_bcm: remove duplicated brcm,bcm4330-bt compatible
WARNING: Unknown commit id '81534d4835de', maybe rebased or not pulled?
#9: 
Fixes: 81534d4835de ("Bluetooth: btbcm: Add BCM4330 and BCM4334 compatibles")

total: 0 errors, 1 warnings, 7 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] Bluetooth: hci_bcm: remove duplicated brcm,bcm4330-bt" has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - PASS - 0.10 seconds
Run gitlint with rule in .gitlint


##############################
Test: BuildKernel - PASS - 519.20 seconds
Build Kernel with minimal configuration supports Bluetooth


##############################
Test: TestRunner: Setup - PASS - 345.93 seconds
Setup environment for running Test Runner


##############################
Test: TestRunner: l2cap-tester - PASS - 2.70 seconds
Run test-runner with l2cap-tester
Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: bnep-tester - PASS - 1.93 seconds
Run test-runner with bnep-tester
Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: mgmt-tester - PASS - 31.31 seconds
Run test-runner with mgmt-tester
Total: 452, Passed: 452 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: rfcomm-tester - PASS - 2.09 seconds
Run test-runner with rfcomm-tester
Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: sco-tester - PASS - 2.12 seconds
Run test-runner with sco-tester
Total: 11, Passed: 11 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: smp-tester - PASS - 2.16 seconds
Run test-runner with smp-tester
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: userchan-tester - PASS - 1.95 seconds
Run test-runner with userchan-tester
Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0



---
Regards,
Linux Bluetooth


[-- Attachment #2: l2cap-tester.log --]
[-- Type: application/octet-stream, Size: 51568 bytes --]

[-- Attachment #3: bnep-tester.log --]
[-- Type: application/octet-stream, Size: 3934 bytes --]

[-- Attachment #4: mgmt-tester.log --]
[-- Type: application/octet-stream, Size: 626845 bytes --]

[-- Attachment #5: rfcomm-tester.log --]
[-- Type: application/octet-stream, Size: 14791 bytes --]

[-- Attachment #6: sco-tester.log --]
[-- Type: application/octet-stream, Size: 13045 bytes --]

[-- Attachment #7: smp-tester.log --]
[-- Type: application/octet-stream, Size: 11859 bytes --]

[-- Attachment #8: userchan-tester.log --]
[-- Type: application/octet-stream, Size: 6516 bytes --]

Re: Bluetooth: hci_bcm: remove duplicated brcm,bcm4330-bt compatible

[Krzysztof Kozlowski]

On 16/09/2021 20:06, bluez.test.bot@gmail.com wrote:
> This is automated email and please do not reply to this email!
> 
> Dear submitter,
> 
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=548291
> 
> ---Test result---
> 
> Test Summary:
> CheckPatch                    FAIL      0.44 seconds
> GitLint                       PASS      0.10 seconds
> BuildKernel                   PASS      519.20 seconds
> TestRunner: Setup             PASS      345.93 seconds
> TestRunner: l2cap-tester      PASS      2.70 seconds
> TestRunner: bnep-tester       PASS      1.93 seconds
> TestRunner: mgmt-tester       PASS      31.31 seconds
> TestRunner: rfcomm-tester     PASS      2.09 seconds
> TestRunner: sco-tester        PASS      2.12 seconds
> TestRunner: smp-tester        PASS      2.16 seconds
> TestRunner: userchan-tester   PASS      1.95 seconds
> 
> Details
> ##############################
> Test: CheckPatch - FAIL - 0.44 seconds
> Run checkpatch.pl script with rule in .checkpatch.conf
> Bluetooth: hci_bcm: remove duplicated brcm,bcm4330-bt compatible
> WARNING: Unknown commit id '81534d4835de', maybe rebased or not pulled?
> #9: 
> Fixes: 81534d4835de ("Bluetooth: btbcm: Add BCM4330 and BCM4334 compatibles")

Although you asked not to reply to this email, but you also sent it to
public mailing list, so I will reply.

Your report is incorrect. Commit ID 81534d4835de is from mainline,
merged into Linus' tree as: v5.13-rc1~94^2~197^2~38

> 
> total: 0 errors, 1 warnings, 7 lines checked
> 
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
> 
> "[PATCH] Bluetooth: hci_bcm: remove duplicated brcm,bcm4330-bt" has style problems, please review.
> 
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.

Checkpatch does not report any warnings like that, so this is false
positive of your system, not checkpatch.



Best regards,
Krzysztof

Re: Bluetooth: hci_bcm: remove duplicated brcm,bcm4330-bt compatible

[Tedd Ho-Jeong An]

Hi 

On Thu, 2021-09-16 at 21:26 +0200, Krzysztof Kozlowski wrote:
> On 16/09/2021 20:06, bluez.test.bot@gmail.com wrote:
> > This is automated email and please do not reply to this email!
> > 
> > Dear submitter,
> > 
> > Thank you for submitting the patches to the linux bluetooth mailing list.
> > This is a CI test results with your patch series:
> > PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=548291
> > 
> > ---Test result---
> > 
> > Test Summary:
> > CheckPatch                    FAIL      0.44 seconds
> > GitLint                       PASS      0.10 seconds
> > BuildKernel                   PASS      519.20 seconds
> > TestRunner: Setup             PASS      345.93 seconds
> > TestRunner: l2cap-tester      PASS      2.70 seconds
> > TestRunner: bnep-tester       PASS      1.93 seconds
> > TestRunner: mgmt-tester       PASS      31.31 seconds
> > TestRunner: rfcomm-tester     PASS      2.09 seconds
> > TestRunner: sco-tester        PASS      2.12 seconds
> > TestRunner: smp-tester        PASS      2.16 seconds
> > TestRunner: userchan-tester   PASS      1.95 seconds
> > 
> > Details
> > ##############################
> > Test: CheckPatch - FAIL - 0.44 seconds
> > Run checkpatch.pl script with rule in .checkpatch.conf
> > Bluetooth: hci_bcm: remove duplicated brcm,bcm4330-bt compatible
> > WARNING: Unknown commit id '81534d4835de', maybe rebased or not pulled?
> > #9: 
> > Fixes: 81534d4835de ("Bluetooth: btbcm: Add BCM4330 and BCM4334 compatibles")
> 
> Although you asked not to reply to this email, but you also sent it to
> public mailing list, so I will reply.
> 
> Your report is incorrect. Commit ID 81534d4835de is from mainline,
> merged into Linus' tree as: v5.13-rc1~94^2~197^2~38
> 
> > total: 0 errors, 1 warnings, 7 lines checked
> > 
> > NOTE: For some of the reported defects, checkpatch may be able to
> >       mechanically convert to the typical style using --fix or --fix-inplace.
> > 
> > "[PATCH] Bluetooth: hci_bcm: remove duplicated brcm,bcm4330-bt" has style problems, please
> > review.
> > 
> > NOTE: If any of the errors are false positives, please report
> >       them to the maintainer, see CHECKPATCH in MAINTAINERS.
> 
> Checkpatch does not report any warnings like that, so this is false
> positive of your system, not checkpatch.
> 
It is a known issue and will be fixed soon.
Sorry for the trouble.


> 
> 
> Best regards,
> Krzysztof

Regards,
Tedd

Re: [PATCH] Bluetooth: hci_bcm: remove duplicated brcm,bcm4330-bt compatible

[Linus Walleij]

On Thu, Sep 16, 2021 at 7:05 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:

> brcm,bcm4330-bt is already on the list.
>
> Fixes: 81534d4835de ("Bluetooth: btbcm: Add BCM4330 and BCM4334 compatibles")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Ooops.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij