[PATCH] Bluetooth: hci_conn: Use kzalloc for kmalloc+memset

[PATCH] Bluetooth: hci_conn: Use kzalloc for kmalloc+memset

[Deepak R Varma]

Use of kzalloc preferred over combination of kmalloc & memset. Issue
identified using coccicheck.

Signed-off-by: Deepak R Varma <drv@mailo.com>
---
 net/bluetooth/hci_conn.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index 7a59c4487050..287d313aa312 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -824,11 +824,10 @@ static int hci_le_terminate_big(struct hci_dev *hdev, u8 big, u8 bis)

 	bt_dev_dbg(hdev, "big 0x%2.2x bis 0x%2.2x", big, bis);

-	d = kmalloc(sizeof(*d), GFP_KERNEL);
+	d = kzalloc(sizeof(*d), GFP_KERNEL);
 	if (!d)
 		return -ENOMEM;

-	memset(d, 0, sizeof(*d));
 	d->big = big;
 	d->bis = bis;

@@ -861,11 +860,10 @@ static int hci_le_big_terminate(struct hci_dev *hdev, u8 big, u16 sync_handle)

 	bt_dev_dbg(hdev, "big 0x%2.2x sync_handle 0x%4.4x", big, sync_handle);

-	d = kmalloc(sizeof(*d), GFP_KERNEL);
+	d = kzalloc(sizeof(*d), GFP_KERNEL);
 	if (!d)
 		return -ENOMEM;

-	memset(d, 0, sizeof(*d));
 	d->big = big;
 	d->sync_handle = sync_handle;

--
2.34.1

RE: Bluetooth: hci_conn: Use kzalloc for kmalloc+memset

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=694573

---Test result---

Test Summary:
CheckPatch                    PASS      0.91 seconds
GitLint                       PASS      0.47 seconds
SubjectPrefix                 PASS      0.30 seconds
BuildKernel                   PASS      48.47 seconds
BuildKernel32                 PASS      42.93 seconds
Incremental Build with patchesPASS      67.14 seconds
TestRunner: Setup             PASS      695.23 seconds
TestRunner: l2cap-tester      PASS      21.64 seconds
TestRunner: iso-tester        PASS      22.88 seconds
TestRunner: bnep-tester       PASS      8.53 seconds
TestRunner: mgmt-tester       PASS      139.53 seconds
TestRunner: rfcomm-tester     PASS      13.29 seconds
TestRunner: sco-tester        PASS      12.53 seconds
TestRunner: ioctl-tester      PASS      14.65 seconds
TestRunner: mesh-tester       PASS      10.41 seconds
TestRunner: smp-tester        PASS      12.32 seconds
TestRunner: userchan-tester   PASS      8.81 seconds



---
Regards,
Linux Bluetooth