public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Bluetooth: msft: Fix error code in msft_cancel_address_filter_sync()
@ 2023-07-03 14:17 Dan Carpenter
  2023-07-03 14:59 ` bluez.test.bot
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Dan Carpenter @ 2023-07-03 14:17 UTC (permalink / raw)
  To: Hilda Wu
  Cc: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz, Alex Lu,
	Simon Horman, linux-bluetooth, kernel-janitors

Return negative -EIO instead of positive EIO.

Fixes: 926df8962f3f ("Bluetooth: msft: Extended monitor tracking by address filter")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 net/bluetooth/msft.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/msft.c b/net/bluetooth/msft.c
index b80a2162a5c3..abbafa6194ca 100644
--- a/net/bluetooth/msft.c
+++ b/net/bluetooth/msft.c
@@ -743,7 +743,7 @@ static int msft_cancel_address_filter_sync(struct hci_dev *hdev, void *data)
 	if (IS_ERR_OR_NULL(skb)) {
 		bt_dev_err(hdev, "MSFT: Failed to cancel address (%pMR) filter",
 			   &address_filter->bdaddr);
-		err = EIO;
+		err = -EIO;
 		goto done;
 	}
 	kfree_skb(skb);
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: Bluetooth: msft: Fix error code in msft_cancel_address_filter_sync()
  2023-07-03 14:17 [PATCH] Bluetooth: msft: Fix error code in msft_cancel_address_filter_sync() Dan Carpenter
@ 2023-07-03 14:59 ` bluez.test.bot
  2023-07-05  7:40 ` [PATCH] " Simon Horman
  2023-07-05 23:00 ` patchwork-bot+bluetooth
  2 siblings, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2023-07-03 14:59 UTC (permalink / raw)
  To: linux-bluetooth, dan.carpenter

[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=762052

---Test result---

Test Summary:
CheckPatch                    PASS      0.57 seconds
GitLint                       PASS      0.28 seconds
SubjectPrefix                 PASS      0.10 seconds
BuildKernel                   PASS      33.51 seconds
CheckAllWarning               PASS      36.46 seconds
CheckSparse                   PASS      41.12 seconds
CheckSmatch                   PASS      115.33 seconds
BuildKernel32                 PASS      32.10 seconds
TestRunnerSetup               PASS      460.82 seconds
TestRunner_l2cap-tester       PASS      13.21 seconds
TestRunner_iso-tester         PASS      23.96 seconds
TestRunner_bnep-tester        PASS      5.61 seconds
TestRunner_mgmt-tester        PASS      132.90 seconds
TestRunner_rfcomm-tester      PASS      9.20 seconds
TestRunner_sco-tester         PASS      10.54 seconds
TestRunner_ioctl-tester       PASS      9.73 seconds
TestRunner_mesh-tester        PASS      7.20 seconds
TestRunner_smp-tester         PASS      8.30 seconds
TestRunner_userchan-tester    PASS      5.91 seconds
IncrementalBuild              PASS      30.54 seconds



---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Bluetooth: msft: Fix error code in msft_cancel_address_filter_sync()
  2023-07-03 14:17 [PATCH] Bluetooth: msft: Fix error code in msft_cancel_address_filter_sync() Dan Carpenter
  2023-07-03 14:59 ` bluez.test.bot
@ 2023-07-05  7:40 ` Simon Horman
  2023-07-05 23:00 ` patchwork-bot+bluetooth
  2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2023-07-05  7:40 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Hilda Wu, Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz,
	Alex Lu, linux-bluetooth, kernel-janitors

On Mon, Jul 03, 2023 at 05:17:16PM +0300, Dan Carpenter wrote:
> Return negative -EIO instead of positive EIO.
> 
> Fixes: 926df8962f3f ("Bluetooth: msft: Extended monitor tracking by address filter")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Reviewed-by: Simon Horman <simon.horman@corigine.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Bluetooth: msft: Fix error code in msft_cancel_address_filter_sync()
  2023-07-03 14:17 [PATCH] Bluetooth: msft: Fix error code in msft_cancel_address_filter_sync() Dan Carpenter
  2023-07-03 14:59 ` bluez.test.bot
  2023-07-05  7:40 ` [PATCH] " Simon Horman
@ 2023-07-05 23:00 ` patchwork-bot+bluetooth
  2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+bluetooth @ 2023-07-05 23:00 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: hildawu, marcel, johan.hedberg, luiz.dentz, alex_lu, simon.horman,
	linux-bluetooth, kernel-janitors

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Mon, 3 Jul 2023 17:17:16 +0300 you wrote:
> Return negative -EIO instead of positive EIO.
> 
> Fixes: 926df8962f3f ("Bluetooth: msft: Extended monitor tracking by address filter")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  net/bluetooth/msft.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - Bluetooth: msft: Fix error code in msft_cancel_address_filter_sync()
    https://git.kernel.org/bluetooth/bluetooth-next/c/375f2744ab84

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-07-05 23:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-03 14:17 [PATCH] Bluetooth: msft: Fix error code in msft_cancel_address_filter_sync() Dan Carpenter
2023-07-03 14:59 ` bluez.test.bot
2023-07-05  7:40 ` [PATCH] " Simon Horman
2023-07-05 23:00 ` patchwork-bot+bluetooth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox