From: Zhao Forrest <forrest.zhao@gmail.com>
To: Patrick Ohly <patrick.ohly@intel.com>
Cc: "Zhao, Forrest" <forrest.zhao@intel.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] Implements the OBEX server/SyncML client binding for syncEvolution (http://syncevolution.org/).
Date: Tue, 20 Oct 2009 17:05:31 +0800 [thread overview]
Message-ID: <ac8af0be0910200205q3c3b57a6o4bd66870c8c4778a@mail.gmail.com> (raw)
In-Reply-To: <1256023119.9142.19.camel@pohly-mobl1.ikn.intel.com>
>> --- a/src/main.c
>> +++ b/src/main.c
>> @@ -53,6 +53,7 @@
>> #define OPP_CHANNEL 9
>> #define FTP_CHANNEL 10
>> #define PBAP_CHANNEL 15
>> +#define SYNCEVOLUTION_CHANNEL 16
>> #define PCSUITE_CHANNEL 24
>
> Do we want to call this "SYNCEVOLUTION" or "SYNCML"? Both has pros and
> cons. Treating it as generic SyncML capability hides the detail that
> it's currently based on SyncEvolution. Exposing SyncEvolution itself
> would allow to activate multiple different SyncML implementations at the
> same time.
>
> My preference would be to keep it as is, but I wanted to ask anyway.
I have the same idea as you do, and prefer to keep it as "SYNCEVOLUTION".
>
> Off topic: what is the "PC Suite Services server"?
>
It's Nokia OBEX PC Suite Services. Johan may know more details about it.
>> + { "syncevolution", 'e', 0, G_OPTION_ARG_NONE, &option_syncevolution,
>> + "Enable OBEX server for Syncevolution client" },
>
> Mind the spelling: "syncevolution" (lower case) is the command line
> tool, "SyncEvolution" (camel case) the project. "Syncevolution" is a
> typo ;-)
>
Will fix it ASAP.
> Is there documentation that should be updated together with introducing
> the new feature?
The patch does not introduce any new d-bus API to obexd, so no doc need to
be updated.
>
>> + if (option_syncevolution == TRUE) {
>> + services |= OBEX_SYNCEVOLUTION;
>> + bluetooth_init(OBEX_SYNCEVOLUTION, "OBEX server for"
>> + " Syncevolution client", NULL,
>> + SYNCEVOLUTION_CHANNEL, TRUE, FALSE, FALSE,
>> + NULL);
>> + }
>> +
>
> Which string is going to appear in the service description (the SDP
> part)? This one here? Mentioning "SyncML" would be useful. So I suggest
> "OBEX server for SyncML, using SyncEvolution". Leave out the
> "SyncEvolution client", because the term client is a) overloaded
> (SyncML/OBEX/D-Bus) and b) SyncEvolution could be both client and server
> in this context (SAN => SyncML client, SyncML message => SyncML server).
>
OK. Will expose service name as "OBEX server for SyncML, using SyncEvolution"
since ProviderName attribute is not supported by obexd now.
next prev parent reply other threads:[~2009-10-20 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 2:58 [PATCH] Implements the OBEX server/SyncML client binding for syncEvolution (http://syncevolution.org/) Forrest Zhao
2009-10-20 7:18 ` Patrick Ohly
2009-10-20 7:39 ` Iain Hibbert
2009-10-20 9:05 ` Zhao Forrest [this message]
2009-10-20 13:18 ` João Paulo Rechi Vita
2009-10-21 1:26 ` Zhao Forrest
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac8af0be0910200205q3c3b57a6o4bd66870c8c4778a@mail.gmail.com \
--to=forrest.zhao@gmail.com \
--cc=forrest.zhao@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=patrick.ohly@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox