* [PATCH v2 0/2] Enable bluetooth on BeagleV-Ahead @ 2026-10-20 13:26 Thomas Gerner 2026-10-20 13:26 ` [PATCH v2 1/2] Bluetooth: btbcm: disable read tx power for BeagleV-Ahead Thomas Gerner 2026-10-20 13:26 ` [PATCH v2 2/2] riscv: dts: thead: Enable bluetooth on BeagleV-Ahead Thomas Gerner 0 siblings, 2 replies; 6+ messages in thread From: Thomas Gerner @ 2026-10-20 13:26 UTC (permalink / raw) To: Marcel Holtmann, Luiz Augusto von Dentz, Drew Fustini, Guo Ren, Fu Wei, Rob Herring, Krzysztof Kozlowski Cc: Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, linux-bluetooth, linux-kernel, linux-riscv, devicetree, Thomas Gerner The single board system BeagleV-Ahead uses a Ampak AP6203BM chip for wifi and bluetooth. Wifi is already enabled for this board. The bluetooth module of the chip connects by UART and PCM to the TH1520 SOC. The PCM interface is currently not used because of missing I2S drivers for the SOC. This patch set enables bluetooth. Thomas Gerner (2): riscv: dts: thead: Enable bluetooth on BeagleV-Ahead Bluetooth: btbcm: disable read tx power for BeagleV-Ahead .../boot/dts/thead/th1520-beaglev-ahead.dts | 85 +++++++++++++++++++ drivers/bluetooth/btbcm.c | 19 ++++- 2 files changed, 101 insertions(+), 3 deletions(-) -- 2.53.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/2] Bluetooth: btbcm: disable read tx power for BeagleV-Ahead 2026-10-20 13:26 [PATCH v2 0/2] Enable bluetooth on BeagleV-Ahead Thomas Gerner @ 2026-10-20 13:26 ` Thomas Gerner 2026-10-20 17:46 ` Enable bluetooth on BeagleV-Ahead bluez.test.bot 2026-11-20 23:53 ` [PATCH v2 1/2] Bluetooth: btbcm: disable read tx power for BeagleV-Ahead Drew Fustini 2026-10-20 13:26 ` [PATCH v2 2/2] riscv: dts: thead: Enable bluetooth on BeagleV-Ahead Thomas Gerner 1 sibling, 2 replies; 6+ messages in thread From: Thomas Gerner @ 2026-10-20 13:26 UTC (permalink / raw) To: Marcel Holtmann, Luiz Augusto von Dentz, Drew Fustini, Guo Ren, Fu Wei, Rob Herring, Krzysztof Kozlowski Cc: Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, linux-bluetooth, linux-kernel, linux-riscv, devicetree, Thomas Gerner The bluetooth module of the Ampak AP6203BM is identified by the btbcm driver as BCM4362A2. The firmware of the bluetooth module on the BeagleV-Ahead reports a capability of reading LE tx power. However reading fails. To get bluetooth working it is necessary to disable reading of LE tx power on the BeagleV-Ahead board. The disable is implemented in a similar way as for several Apple boards but uses the board compatible identification from the DTB as there is no DMI. Signed-off-by: Thomas Gerner <thomas.gerner@muenchen-mail.de> --- No changes in v2 drivers/bluetooth/btbcm.c | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c index 463d59890bef..2d02cc1863d0 100644 --- a/drivers/bluetooth/btbcm.c +++ b/drivers/bluetooth/btbcm.c @@ -436,6 +436,11 @@ static const struct dmi_system_id disable_broken_read_transmit_power[] = { { } }; +static const char *board_broken_read_transmit_power[] __maybe_unused = { + "beagle,beaglev-ahead", + NULL +}; + static int btbcm_read_info(struct hci_dev *hdev) { struct sk_buff *skb; @@ -537,12 +542,13 @@ static const struct bcm_subver_table bcm_usb_subver_table[] = { * This currently only looks up the device tree board appendix, * but can be expanded to other mechanisms. */ -static const char *btbcm_get_board_name(struct device *dev) +static const char *btbcm_get_board_name(struct hci_dev *hdev) { #ifdef CONFIG_OF struct device_node *root __free(device_node) = of_find_node_by_path("/"); char *board_type; const char *tmp; + const char **s; if (!root) return NULL; @@ -550,8 +556,15 @@ static const char *btbcm_get_board_name(struct device *dev) if (of_property_read_string_index(root, "compatible", 0, &tmp)) return NULL; + /* disable broken Read LE Min/Max Tx Power on first board found in list */ + for (s = board_broken_read_transmit_power; *s; s++) + if (!strcmp(tmp, *s)) { + hci_set_quirk(hdev, HCI_QUIRK_BROKEN_READ_TRANSMIT_POWER); + break; + } + /* get rid of any '/' in the compatible string */ - board_type = devm_kstrdup(dev, tmp, GFP_KERNEL); + board_type = devm_kstrdup(&hdev->dev, tmp, GFP_KERNEL); if (!board_type) return NULL; @@ -577,7 +590,7 @@ int btbcm_initialize(struct hci_dev *hdev, bool *fw_load_done, bool use_autobaud const struct firmware *fw; int i, err; - board_name = btbcm_get_board_name(&hdev->dev); + board_name = btbcm_get_board_name(hdev); /* Reset */ err = btbcm_reset(hdev); -- 2.53.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: Enable bluetooth on BeagleV-Ahead 2026-10-20 13:26 ` [PATCH v2 1/2] Bluetooth: btbcm: disable read tx power for BeagleV-Ahead Thomas Gerner @ 2026-10-20 17:46 ` bluez.test.bot 2026-11-20 23:53 ` [PATCH v2 1/2] Bluetooth: btbcm: disable read tx power for BeagleV-Ahead Drew Fustini 1 sibling, 0 replies; 6+ messages in thread From: bluez.test.bot @ 2026-10-20 17:46 UTC (permalink / raw) To: linux-bluetooth, thomas.gerner [-- Attachment #1: Type: text/plain, Size: 2935 bytes --] This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/series/1189748/ ---Test result--- Test Summary: CheckPatch FAIL 1.16 seconds VerifyFixes PASS 3.32 seconds VerifySignedoff PASS 0.23 seconds GitLint FAIL 0.54 seconds SubjectPrefix FAIL 0.14 seconds BuildKernel PASS 29.63 seconds CheckAllWarning PASS 33.37 seconds CheckSparse PASS 35.85 seconds BuildKernel32 PASS 29.33 seconds CheckKernelLLVM PASS 33.33 seconds TestRunnerSetup PASS 696.58 seconds TestRunner_l2cap-tester PASS 12.78 seconds TestRunner_iso-tester PASS 10.60 seconds TestRunner_bnep-tester PASS 3.05 seconds TestRunner_mgmt-tester PASS 87.27 seconds TestRunner_rfcomm-tester PASS 4.40 seconds TestRunner_sco-tester PASS 5.60 seconds TestRunner_ioctl-tester PASS 4.60 seconds TestRunner_mesh-tester PASS 5.41 seconds TestRunner_smp-tester PASS 4.29 seconds TestRunner_userchan-tester PASS 3.14 seconds TestRunner_6lowpan-tester PASS 4.34 seconds IncrementalBuild PASS 28.77 seconds Details ############################## Test: CheckPatch - FAIL Desc: Run checkpatch.pl script Output: [v2,2/2] riscv: dts: thead: Enable bluetooth on BeagleV-Ahead WARNING: please, no space before tabs #239: FILE: arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts:397: +^I^Ishutdown-gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>; ^I/* BT-REG-ON */$ total: 0 errors, 1 warnings, 106 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /home/runner/work/bluetooth-next/bluetooth-next/src/patch/14902974.patch has style problems, please review. NOTE: Ignored message types: UNKNOWN_COMMIT_ID NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. ############################## Test: GitLint - FAIL Desc: Run gitlint Output: [v2,2/2] riscv: dts: thead: Enable bluetooth on BeagleV-Ahead 11: B3 Line contains hard tab characters (\t): " - use default pinctrl definition for bluetooth in and out pins" 12: B2 Line has trailing whitespace: " " 12: B3 Line contains hard tab characters (\t): " " ############################## Test: SubjectPrefix - FAIL Desc: Check subject contains "Bluetooth" prefix Output: "Bluetooth: " prefix is not specified in the subject https://github.com/bluez/bluetooth-next/pull/968 --- Regards, Linux Bluetooth ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] Bluetooth: btbcm: disable read tx power for BeagleV-Ahead 2026-10-20 13:26 ` [PATCH v2 1/2] Bluetooth: btbcm: disable read tx power for BeagleV-Ahead Thomas Gerner 2026-10-20 17:46 ` Enable bluetooth on BeagleV-Ahead bluez.test.bot @ 2026-11-20 23:53 ` Drew Fustini 1 sibling, 0 replies; 6+ messages in thread From: Drew Fustini @ 2026-11-20 23:53 UTC (permalink / raw) To: Thomas Gerner Cc: Marcel Holtmann, Luiz Augusto von Dentz, Guo Ren, Fu Wei, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, linux-bluetooth, linux-kernel, linux-riscv, devicetree On Tue, Oct 20, 2026 at 03:26:03PM +0200, Thomas Gerner wrote: > The bluetooth module of the Ampak AP6203BM is identified by the btbcm > driver as BCM4362A2. > > The firmware of the bluetooth module on the BeagleV-Ahead reports a > capability of reading LE tx power. However reading fails. To get > bluetooth working it is necessary to disable reading of LE tx power on > the BeagleV-Ahead board. The disable is implemented in a similar way as > for several Apple boards but uses the board compatible identification > from the DTB as there is no DMI. Thanks for sending this patch. Do you know if this is a problem on any other boards with the AP6203BM? Also, is there an error message for the failed read? > > Signed-off-by: Thomas Gerner <thomas.gerner@muenchen-mail.de> > --- > No changes in v2 > > drivers/bluetooth/btbcm.c | 19 ++++++++++++++++--- > 1 file changed, 16 insertions(+), 3 deletions(-) > > diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c > index 463d59890bef..2d02cc1863d0 100644 > --- a/drivers/bluetooth/btbcm.c > +++ b/drivers/bluetooth/btbcm.c [..] > -static const char *btbcm_get_board_name(struct device *dev) > +static const char *btbcm_get_board_name(struct hci_dev *hdev) > { > #ifdef CONFIG_OF > struct device_node *root __free(device_node) = of_find_node_by_path("/"); > char *board_type; > const char *tmp; > + const char **s; > > if (!root) > return NULL; > @@ -550,8 +556,15 @@ static const char *btbcm_get_board_name(struct device *dev) > if (of_property_read_string_index(root, "compatible", 0, &tmp)) > return NULL; > > + /* disable broken Read LE Min/Max Tx Power on first board found in list */ > + for (s = board_broken_read_transmit_power; *s; s++) > + if (!strcmp(tmp, *s)) { > + hci_set_quirk(hdev, HCI_QUIRK_BROKEN_READ_TRANSMIT_POWER); > + break; > + } It seems that btbcm_get_board_name() only looks up the board name for the firmware file so I think it could be unexpected to set a quirk here. Maybe this would work better? static const char * const board_broken_read_transmit_power[] = { "beagle,beaglev-ahead", NULL }; [..] if (dmi_first_match(disable_broken_read_transmit_power)) hci_set_quirk(hdev, HCI_QUIRK_BROKEN_READ_TRANSMIT_POWER); if (of_machine_compatible_match(board_broken_read_transmit_power)) hci_set_quirk(hdev, HCI_QUIRK_BROKEN_READ_TRANSMIT_POWER); However, I am not very familiar with Bluetooth drivers so I am hoping Marcel or Luiz can comment too. Thanks, Drew ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] riscv: dts: thead: Enable bluetooth on BeagleV-Ahead 2026-10-20 13:26 [PATCH v2 0/2] Enable bluetooth on BeagleV-Ahead Thomas Gerner 2026-10-20 13:26 ` [PATCH v2 1/2] Bluetooth: btbcm: disable read tx power for BeagleV-Ahead Thomas Gerner @ 2026-10-20 13:26 ` Thomas Gerner 2026-11-20 23:34 ` Drew Fustini 1 sibling, 1 reply; 6+ messages in thread From: Thomas Gerner @ 2026-10-20 13:26 UTC (permalink / raw) To: Marcel Holtmann, Luiz Augusto von Dentz, Drew Fustini, Guo Ren, Fu Wei, Rob Herring, Krzysztof Kozlowski Cc: Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, linux-bluetooth, linux-kernel, linux-riscv, devicetree, Thomas Gerner On the BeagleV-Ahead the bluetooth module of the Ampak AP6203BM is identified by the btbcm driver as BCM4362A2. The module is connected by UART4, several gpio pins and an I2S interface. The I2S is currently not used as there is currently no driver. Signed-off-by: Thomas Gerner <thomas.gerner@muenchen-mail.de> --- Changes in v2: - use default pinctrl definition for bluetooth in and out pins .../boot/dts/thead/th1520-beaglev-ahead.dts | 85 +++++++++++++++++++ 1 file changed, 85 insertions(+) diff --git a/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts index e16484a47653..7161a9d4c61f 100644 --- a/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts +++ b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts @@ -76,6 +76,23 @@ led-5 { }; }; + reg_vbat_1v8: regulator-vbat-1v8 { + compatible = "regulator-fixed"; + regulator-boot-on; + regulator-max-microvolt = <1800000>; + regulator-min-microvolt = <1800000>; + regulator-name = "vbat-1v8"; + }; + + reg_vbat_3v3: regulator-vbat-3v3 { + compatible = "regulator-fixed"; + enable-active-high; + regulator-boot-on; + regulator-max-microvolt = <3300000>; + regulator-min-microvolt = <3300000>; + regulator-name = "vbat-3v3"; + }; + hdmi-connector { compatible = "hdmi-connector"; type = "d"; @@ -152,6 +169,28 @@ led-pins { }; &padctrl0_apsys { + bluetooth_pins: bluetooth-0 { + in-pins { + bias-disable; + drive-strength = <1>; + function = "gpio"; + input-enable; + input-schmitt-enable; + pins = "GPIO2_30"; + slew-rate = <0>; + }; + + out-pins { + bias-disable; + drive-strength = <3>; + input-disable; + input-schmitt-disable; + pins = "SDIO1_DETN", /* GPIO2_29 */ + "SDIO1_WPRTN"; /* GPIO2_28 */ + slew-rate = <0>; + }; + }; + gmac0_pins: gmac0-0 { tx-pins { pins = "GMAC0_TX_CLK", @@ -268,6 +307,30 @@ reg-on-pins { }; }; +&padctrl1_apsys { + uart4_pins: uart4-0 { + rx-pins { + bias-disable; + drive-strength = <1>; + function = "uart"; + input-enable; + pins = "UART4_RXD", "UART4_CTSN"; + input-schmitt-enable; + slew-rate = <0>; + }; + + tx-pins { + bias-disable; + drive-strength = <3>; + function = "uart"; + input-disable; + pins = "UART4_TXD", "UART4_RTSN"; + input-schmitt-disable; + slew-rate = <0>; + }; + }; +}; + &sdio0 { bus-width = <4>; max-frequency = <198000000>; @@ -314,3 +377,25 @@ &uart0 { pinctrl-0 = <&uart0_pins>; status = "okay"; }; + +&uart4 { + pinctrl-0 = <&uart4_pins>; + pinctrl-names = "default"; + uart-has-rtscts; + + status = "okay"; + + bluetooth { + compatible = "brcm,bcm4329-bt"; + device-wakeup-gpios = <&gpio2 29 GPIO_ACTIVE_HIGH>; + interrupt-parent = <&gpio2>; + interrupts = <30 IRQ_TYPE_EDGE_RISING>; + interrupt-names = "host-wakeup"; + max-speed = <921600>; + pinctrl-0 = <&bluetooth_pins>; + pinctrl-names = "default"; + shutdown-gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>; /* BT-REG-ON */ + vbat-supply = <®_vbat_3v3>; + vddio-supply = <®_vbat_1v8>; + }; +}; -- 2.53.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] riscv: dts: thead: Enable bluetooth on BeagleV-Ahead 2026-10-20 13:26 ` [PATCH v2 2/2] riscv: dts: thead: Enable bluetooth on BeagleV-Ahead Thomas Gerner @ 2026-11-20 23:34 ` Drew Fustini 0 siblings, 0 replies; 6+ messages in thread From: Drew Fustini @ 2026-11-20 23:34 UTC (permalink / raw) To: Thomas Gerner Cc: Marcel Holtmann, Luiz Augusto von Dentz, Guo Ren, Fu Wei, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, linux-bluetooth, linux-kernel, linux-riscv, devicetree On Tue, Oct 20, 2026 at 03:26:04PM +0200, Thomas Gerner wrote: > On the BeagleV-Ahead the bluetooth module of the Ampak AP6203BM is > identified by the btbcm driver as BCM4362A2. The module is connected by > UART4, several gpio pins and an I2S interface. The I2S is currently not > used as there is currently no driver. > > Signed-off-by: Thomas Gerner <thomas.gerner@muenchen-mail.de> > --- > Changes in v2: > - use default pinctrl definition for bluetooth in and out pins Thanks for sending v2. Sorry for the delay in review. > > .../boot/dts/thead/th1520-beaglev-ahead.dts | 85 +++++++++++++++++++ > 1 file changed, 85 insertions(+) > > diff --git a/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts > index e16484a47653..7161a9d4c61f 100644 > --- a/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts > +++ b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts > @@ -76,6 +76,23 @@ led-5 { > }; > }; > > + reg_vbat_1v8: regulator-vbat-1v8 { > + compatible = "regulator-fixed"; > + regulator-boot-on; > + regulator-max-microvolt = <1800000>; > + regulator-min-microvolt = <1800000>; > + regulator-name = "vbat-1v8"; > + }; > + > + reg_vbat_3v3: regulator-vbat-3v3 { > + compatible = "regulator-fixed"; > + enable-active-high; enable-active-high has no effect without a gpio. > + regulator-boot-on; > + regulator-max-microvolt = <3300000>; > + regulator-min-microvolt = <3300000>; > + regulator-name = "vbat-3v3"; > + }; Nothing can switch these two rails so regulator-always-on describes them better than regulator-boot-on. > + > hdmi-connector { > compatible = "hdmi-connector"; > type = "d"; > @@ -152,6 +169,28 @@ led-pins { > }; > > &padctrl0_apsys { > + bluetooth_pins: bluetooth-0 { > + in-pins { > + bias-disable; > + drive-strength = <1>; > + function = "gpio"; > + input-enable; > + input-schmitt-enable; > + pins = "GPIO2_30"; > + slew-rate = <0>; > + }; > + > + out-pins { > + bias-disable; > + drive-strength = <3>; > + input-disable; > + input-schmitt-disable; > + pins = "SDIO1_DETN", /* GPIO2_29 */ > + "SDIO1_WPRTN"; /* GPIO2_28 */ > + slew-rate = <0>; > + }; > + }; > + > gmac0_pins: gmac0-0 { > tx-pins { > pins = "GMAC0_TX_CLK", > @@ -268,6 +307,30 @@ reg-on-pins { > }; > }; > > +&padctrl1_apsys { > + uart4_pins: uart4-0 { > + rx-pins { > + bias-disable; > + drive-strength = <1>; > + function = "uart"; > + input-enable; > + pins = "UART4_RXD", "UART4_CTSN"; > + input-schmitt-enable; > + slew-rate = <0>; > + }; > + > + tx-pins { > + bias-disable; > + drive-strength = <3>; > + function = "uart"; > + input-disable; > + pins = "UART4_TXD", "UART4_RTSN"; > + input-schmitt-disable; > + slew-rate = <0>; > + }; > + }; > +}; > + > &sdio0 { > bus-width = <4>; > max-frequency = <198000000>; > @@ -314,3 +377,25 @@ &uart0 { > pinctrl-0 = <&uart0_pins>; > status = "okay"; > }; > + > +&uart4 { > + pinctrl-0 = <&uart4_pins>; > + pinctrl-names = "default"; > + uart-has-rtscts; > + > + status = "okay"; > + > + bluetooth { > + compatible = "brcm,bcm4329-bt"; > + device-wakeup-gpios = <&gpio2 29 GPIO_ACTIVE_HIGH>; > + interrupt-parent = <&gpio2>; > + interrupts = <30 IRQ_TYPE_EDGE_RISING>; > + interrupt-names = "host-wakeup"; > + max-speed = <921600>; > + pinctrl-0 = <&bluetooth_pins>; > + pinctrl-names = "default"; > + shutdown-gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>; /* BT-REG-ON */ This triggers checkpatch: WARNING: please, no space before tabs #230: FILE: arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts:397: +^I^Ishutdown-gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>; ^I/* BT-REG-ON */$ > + vbat-supply = <®_vbat_3v3>; > + vddio-supply = <®_vbat_1v8>; > + }; > +}; > -- > 2.53.0 > Thanks, Drew ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-11-20 23:53 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-10-20 13:26 [PATCH v2 0/2] Enable bluetooth on BeagleV-Ahead Thomas Gerner 2026-10-20 13:26 ` [PATCH v2 1/2] Bluetooth: btbcm: disable read tx power for BeagleV-Ahead Thomas Gerner 2026-10-20 17:46 ` Enable bluetooth on BeagleV-Ahead bluez.test.bot 2026-11-20 23:53 ` [PATCH v2 1/2] Bluetooth: btbcm: disable read tx power for BeagleV-Ahead Drew Fustini 2026-10-20 13:26 ` [PATCH v2 2/2] riscv: dts: thead: Enable bluetooth on BeagleV-Ahead Thomas Gerner 2026-11-20 23:34 ` Drew Fustini
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox