Linux bluetooth development
 help / color / mirror / Atom feed
* [bluez/bluez] 51f3a3: device: fix inverted NULL check in gatt_db clone
@ 2026-05-18  9:01 github-actions[bot]
  0 siblings, 0 replies; only message in thread
From: github-actions[bot] @ 2026-05-18  9:01 UTC (permalink / raw)
  To: linux-bluetooth

  Branch: refs/heads/1096354
  Home:   https://github.com/bluez/bluez
  Commit: 51f3a3b221be978d726a4cfc74a30272a24e9e3c
      https://github.com/bluez/bluez/commit/51f3a3b221be978d726a4cfc74a30272a24e9e3c
  Author: Zhao Dongdong <zhaodongdong@kylinos.cn>
  Date:   2026-05-18 (Mon, 18 May 2026)

  Changed paths:
    M src/device.c

  Log Message:
  -----------
  device: fix inverted NULL check in gatt_db clone

gatt_db_clone() returns NULL on failure so the condition was inverted.
With the old check a successful clone (non-NULL) would return false and
skip swapping the device's GATT database, while a failure (NULL) would
fall through and dereference a NULL pointer a few lines below.

Fix by negating the condition: only bail out early if the clone failed;
proceed with the swap when the clone actually succeeds.

Fixes: cbe4144dea6f ("set: Attempt to use existing set gatt-db")
Signed-off-by: Zhao Dongdong <zhaodongdong@kylinos.cn>



To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-05-18  9:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-18  9:01 [bluez/bluez] 51f3a3: device: fix inverted NULL check in gatt_db clone github-actions[bot]

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox