* [bluez/bluez] f00fac: obexd: fix PBAP PullPhoneBook failure with ebook b...
@ 2026-05-22 8:01 github-actions[bot]
0 siblings, 0 replies; only message in thread
From: github-actions[bot] @ 2026-05-22 8:01 UTC (permalink / raw)
To: linux-bluetooth
Branch: refs/heads/1099150
Home: https://github.com/bluez/bluez
Commit: f00faca1eda199fb974b5c58a0011f9e86318954
https://github.com/bluez/bluez/commit/f00faca1eda199fb974b5c58a0011f9e86318954
Author: Zhiyuan Sheng <zhiyuan.sheng@oss.qualcomm.com>
Date: 2026-05-22 (Fri, 22 May 2026)
Changed paths:
M obexd/plugins/pbap.c
M obexd/plugins/phonebook-ebook.c
Log Message:
-----------
obexd: fix PBAP PullPhoneBook failure with ebook backend
phonebook_pull() in phonebook-ebook.c does not set *err = 0 on the
success path, unlike phonebook-tracker.c and phonebook-dummy.c. The
caller vobject_pull_open() in pbap.c declares 'ret' without
initialization and passes &ret to phonebook_pull(), so 'ret' retains
an indeterminate stack value when the ebook backend is in use. The
subsequent 'if (ret < 0)' check then incorrectly triggers and rejects
the request with Internal Server Error.
Fix this by setting *err = 0 on success in phonebook-ebook.c, and
initialize 'ret' to 0 in vobject_pull_open() as a defensive measure
to guard against any backend that omits this assignment.
Signed-off-by: Zhiyuan Sheng <zhiyuan.sheng@oss.qualcomm.com>
To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-05-22 8:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-22 8:01 [bluez/bluez] f00fac: obexd: fix PBAP PullPhoneBook failure with ebook b github-actions[bot]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox