[bluez/bluez] 80e9eb: test-mesh-crypto: Fix retval for skipped test

[bluez/bluez] 80e9eb: test-mesh-crypto: Fix retval for skipped test

[shengzhiyuan]

  Branch: refs/heads/master
  Home:   https://github.com/bluez/bluez
  Commit: 80e9eb51c4c9f60316c189f3498b137bfbbee7d3
      https://github.com/bluez/bluez/commit/80e9eb51c4c9f60316c189f3498b137bfbbee7d3
  Author: Bastien Nocera <hadess@hadess.net>
  Date:   2026-06-05 (Fri, 05 Jun 2026)

  Changed paths:
    M unit/test-mesh-crypto.c

  Log Message:
  -----------
  test-mesh-crypto: Fix retval for skipped test

Skipped tests should return 77, so they will be marked as skipped in
reports:
  $ make check
  make --no-print-directory check-TESTS
  [...]
  PASS: unit/test-gatt
  SKIP: unit/test-mesh-crypto
  [...]
  ============================================================================
  Testsuite summary for bluez 5.86
  ============================================================================
  # TOTAL: 39
  # PASS:  38
  # SKIP:  1
  [...]
  ============================================================================


  Commit: 7a0c8ebf91e69c3b2d2d48f8f4b0074fddde1fa4
      https://github.com/bluez/bluez/commit/7a0c8ebf91e69c3b2d2d48f8f4b0074fddde1fa4
  Author: Zhiyuan Sheng <zhiyuan.sheng@oss.qualcomm.com>
  Date:   2026-06-05 (Fri, 05 Jun 2026)

  Changed paths:
    M obexd/plugins/pbap.c
    M obexd/plugins/phonebook-ebook.c

  Log Message:
  -----------
  obexd: fix PBAP PullPhoneBook failure with ebook backend

phonebook_pull() in phonebook-ebook.c does not set *err = 0 on the
success path, unlike phonebook-tracker.c and phonebook-dummy.c. The
caller vobject_pull_open() in pbap.c declares 'ret' without
initialization and passes &ret to phonebook_pull(), so 'ret' retains
an indeterminate stack value when the ebook backend is in use. The
subsequent 'if (ret < 0)' check then incorrectly triggers and rejects
the request with Internal Server Error.

Fix this by setting *err = 0 on success in phonebook-ebook.c, and
initialize 'ret' to 0 in vobject_pull_open() as a defensive measure
to guard against any backend that omits this assignment.


Compare: https://github.com/bluez/bluez/compare/42b2c543a70c...7a0c8ebf91e6

To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications