Linux btrace development
 help / color / mirror / Atom feed
* [PATCH 1/2] blkparse: remove duplicated entry for flag M
@ 2018-04-07  9:12 Weiping Zhang
  2018-04-09 14:33 ` Steffen Maier
  2018-04-09 14:36 ` Jens Axboe
  0 siblings, 2 replies; 3+ messages in thread
From: Weiping Zhang @ 2018-04-07  9:12 UTC (permalink / raw)
  To: linux-btrace

remove dupliated entry 'M' for man page of blkparse.

Signed-off-by: Weiping Zhang <zhangweiping@didichuxing.com>
---
 doc/blkparse.1 | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/doc/blkparse.1 b/doc/blkparse.1
index be9b34b..b1cb6ef 100644
--- a/doc/blkparse.1
+++ b/doc/blkparse.1
@@ -243,10 +243,6 @@ Same as the back merge, except this i/o ends where a previously inserted
 requests starts.
 
 .HP 4
-\fBM --front or back merge\fR
-One of the above
-
-.HP 4
 \fBM -- front or back merge\fR
 One of the above.
 
-- 
2.9.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] blkparse: remove duplicated entry for flag M
  2018-04-07  9:12 [PATCH 1/2] blkparse: remove duplicated entry for flag M Weiping Zhang
@ 2018-04-09 14:33 ` Steffen Maier
  2018-04-09 14:36 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Steffen Maier @ 2018-04-09 14:33 UTC (permalink / raw)
  To: linux-btrace


On 04/07/2018 11:12 AM, Weiping Zhang wrote:
> remove dupliated entry 'M' for man page of blkparse.
> 
> Signed-off-by: Weiping Zhang <zhangweiping@didichuxing.com>
> ---
>   doc/blkparse.1 | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/doc/blkparse.1 b/doc/blkparse.1
> index be9b34b..b1cb6ef 100644
> --- a/doc/blkparse.1
> +++ b/doc/blkparse.1
> @@ -243,10 +243,6 @@ Same as the back merge, except this i/o ends where a previously inserted
>   requests starts.
> 
>   .HP 4
> -\fBM --front or back merge\fR
> -One of the above
> -
> -.HP 4
>   \fBM -- front or back merge\fR
>   One of the above.
> 

I also found this (and other things) and plan to submit them later.

Additionally, I had the impression that 'M' is nowadays always a "back 
merge", not "front or back merge".

Anyway, dropping the duplicate seems right:

Reviewed-by: Steffen Maier <maier@linux.ibm.com>

-- 
Mit freundlichen Grüßen / Kind regards
Steffen Maier

Linux on z Systems Development

IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] blkparse: remove duplicated entry for flag M
  2018-04-07  9:12 [PATCH 1/2] blkparse: remove duplicated entry for flag M Weiping Zhang
  2018-04-09 14:33 ` Steffen Maier
@ 2018-04-09 14:36 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2018-04-09 14:36 UTC (permalink / raw)
  To: linux-btrace

On 4/9/18 8:33 AM, Steffen Maier wrote:
> 
> On 04/07/2018 11:12 AM, Weiping Zhang wrote:
>> remove dupliated entry 'M' for man page of blkparse.
>>
>> Signed-off-by: Weiping Zhang <zhangweiping@didichuxing.com>
>> ---
>>   doc/blkparse.1 | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/doc/blkparse.1 b/doc/blkparse.1
>> index be9b34b..b1cb6ef 100644
>> --- a/doc/blkparse.1
>> +++ b/doc/blkparse.1
>> @@ -243,10 +243,6 @@ Same as the back merge, except this i/o ends where a previously inserted
>>   requests starts.
>>
>>   .HP 4
>> -\fBM --front or back merge\fR
>> -One of the above
>> -
>> -.HP 4
>>   \fBM -- front or back merge\fR
>>   One of the above.
>>
> 
> I also found this (and other things) and plan to submit them later.
> 
> Additionally, I had the impression that 'M' is nowadays always a "back 
> merge", not "front or back merge".

'M' is a back merge, 'F' is a front merge.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-04-09 14:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-07  9:12 [PATCH 1/2] blkparse: remove duplicated entry for flag M Weiping Zhang
2018-04-09 14:33 ` Steffen Maier
2018-04-09 14:36 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox