Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Remi Gauvin <remi@georgianit.com>,
	Bernd Lentes <bernd.lentes@helmholtz-muenchen.de>,
	Qu Wenruo <wqu@suse.com>,
	linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: question to btrfs scrub
Date: Thu, 6 Jul 2023 14:23:05 +0800	[thread overview]
Message-ID: <00c1ea17-680f-18a0-d40a-f36bcdb9101d@gmx.com> (raw)
In-Reply-To: <743f92ee-19e8-ba45-0426-795a91fc0e0b@georgianit.com>



On 2023/7/6 01:53, Remi Gauvin wrote:
> On 2023-07-05 11:01 a.m., Bernd Lentes wrote:
>
>>> The main thing here is, nodatacow implies nodatacsum, thus it would not
>>> generate any csum nor verify it.
>>
>> But aren't checksums important in case of errors ?
>> OK. I know which VM images produced checksum errors. I delete them and restore them from the backup.
>> Then I set the attribute for the directory.
>>
>> OK ?
>>
>
> I'm really not sure how we jumped to this being a bug that you should
> work around by disabling Csum.  I know Qu mentioned the possibility (and
> I by no means want to question his expertise.)... But unless I missed
> something in this thread, there has been no real indication to not
> simply take the error at face value,, the drive/controller/usb combo
> resulted in corrupt data, BTRFS detected and reported...
>
> I would hope that the error detection working exactly as it is intended
> would be the most likely explanation.

I hate to point my finger to btrfs itself, but I still remember in the
old days some workload can lead to such false alerts.
But I can not recall which commit is causing and which one is fixing the
problem.

Another concern is, the report is using SINGLE for data, which is
completely fine, but it doesn't help us to determine if it's really a
hardware data corruption or btrfs bugs.

If the report is using RAID1, and those corruption are all repairable,
then we're pretty sure it's data corruption on disk.
Or if all mirrors are corrupted in a RAID1* config, then we know it's
definitely btrfs causing the problem.

But with SINGLE profile, it's really hard to say.

Thanks,
Qu

>
> As for what you can do if that's the case, delete the corrupted file and
> see if it happens again, (in which case, buy more reliable hardware.),
> or just skip the wait and go right to (hopefully) better hardware.
>
>

  reply	other threads:[~2023-07-06  6:24 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-29  8:26 question to btrfs scrub Bernd Lentes
2023-06-29  9:08 ` Qu Wenruo
2023-06-30  9:59   ` Bernd Lentes
2023-06-30 10:16     ` Qu Wenruo
2023-07-04 16:03       ` Bernd Lentes
2023-07-04 17:00         ` Bernd Lentes
2023-07-04 22:19         ` Qu Wenruo
2023-07-05  8:39           ` Bernd Lentes
2023-07-05  8:45             ` Qu Wenruo
2023-07-05 15:01               ` Bernd Lentes
2023-07-05 17:53                 ` Remi Gauvin
2023-07-06  6:23                   ` Qu Wenruo [this message]
2023-07-06 13:18                     ` Remi Gauvin
2023-07-07 21:02                       ` Bernd Lentes
2023-07-07 20:54                     ` Bernd Lentes
2023-07-08  5:08                       ` Qu Wenruo
2023-07-18 15:34                         ` Bernd Lentes
2023-07-07 20:40                   ` Bernd Lentes
2023-07-06  6:19                 ` Qu Wenruo
2023-07-06  7:04                   ` Andrei Borzenkov
2023-07-06  7:07                     ` Qu Wenruo
2023-07-07 20:48                   ` Bernd Lentes
2023-07-07 22:17                     ` Qu Wenruo
2023-06-29  9:12 ` Forza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00c1ea17-680f-18a0-d40a-f36bcdb9101d@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=bernd.lentes@helmholtz-muenchen.de \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=remi@georgianit.com \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox