Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.com>
To: Bernd Lentes <bernd.lentes@helmholtz-muenchen.de>,
	Qu Wenruo <quwenruo.btrfs@gmx.com>,
	linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: question to btrfs scrub
Date: Wed, 5 Jul 2023 16:45:58 +0800	[thread overview]
Message-ID: <80136f6f-0575-58e8-ea8d-7053c8af4db0@suse.com> (raw)
In-Reply-To: <PR3PR04MB7340B6C8F2191ED355D1232BD62FA@PR3PR04MB7340.eurprd04.prod.outlook.com>



On 2023/7/5 16:39, Bernd Lentes wrote:
> 
>> -----Original Message-----
>> From: Qu Wenruo <wqu@suse.com>
>> Sent: Wednesday, July 5, 2023 12:19 AM
>> To: Bernd Lentes <bernd.lentes@helmholtz-muenchen.de>; Qu Wenruo
>> <quwenruo.btrfs@gmx.com>; linux-btrfs <linux-btrfs@vger.kernel.org>
>> Subject: Re: question to btrfs scrub
>>
>> That's why it doesn't report the csum error, and we need "--check-data-csum"
>> to verify data csum.
> 
> OK. I started it. But isn't that the same as "btrfs scrub" ?
> The man page gives a hint:
> --check-data-csum
> verify checksums of data blocks
> This expects that the filesystem is otherwise OK, and is basically an offline scrub that does not repair data from spare copies.

Btrfs check has way more comprehensive checks on metadata, but it by 
default not check data csums.

Which is quite the opposite of btrfs scrub, which only checks data csum, 
and metadata checks are very lightweight.

> 
>>> What can I do ? I'm afraid I have to reformat.'
>>
>> Nope, you don't need to reformat at all.
>>
>>> But what be the culprit for the errors ?
>>
>> It can be a problem of the VM workload on btrfs.
> My VM's are not under heavy load.
>>
>> As a workaround, you can easily disable datacow for the VM directory using
>> the following command:
>>
>> # chattr +C <VM images directory>
> 
> No. I use btrfs to make snapshots from the images from the VM's.

NodataCOW would still work with snapshot.

It would still do COW when there are snapshots involved.

The main thing here is, nodatacow implies nodatacsum, thus it would not 
generate any csum nor verify it.

Thanks,
Qu

> 
> Thanks.
> 
> Bernd
> 
> 
> Helmholtz Zentrum München – Deutsches Forschungszentrum für Gesundheit und Umwelt (GmbH)
> Ingolstädter Landstraße 1, D-85764 Neuherberg, https://www.helmholtz-munich.de
> Geschäftsführung: Prof. Dr. med. Dr. h.c. Matthias Tschöp, Daniela Sommer (komm.) | Aufsichtsratsvorsitzende: MinDir’in Prof. Dr. Veronika von Messling
> Registergericht: Amtsgericht München HRB 6466 | USt-IdNr. DE 129521671

  reply	other threads:[~2023-07-05  8:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-29  8:26 question to btrfs scrub Bernd Lentes
2023-06-29  9:08 ` Qu Wenruo
2023-06-30  9:59   ` Bernd Lentes
2023-06-30 10:16     ` Qu Wenruo
2023-07-04 16:03       ` Bernd Lentes
2023-07-04 17:00         ` Bernd Lentes
2023-07-04 22:19         ` Qu Wenruo
2023-07-05  8:39           ` Bernd Lentes
2023-07-05  8:45             ` Qu Wenruo [this message]
2023-07-05 15:01               ` Bernd Lentes
2023-07-05 17:53                 ` Remi Gauvin
2023-07-06  6:23                   ` Qu Wenruo
2023-07-06 13:18                     ` Remi Gauvin
2023-07-07 21:02                       ` Bernd Lentes
2023-07-07 20:54                     ` Bernd Lentes
2023-07-08  5:08                       ` Qu Wenruo
2023-07-18 15:34                         ` Bernd Lentes
2023-07-07 20:40                   ` Bernd Lentes
2023-07-06  6:19                 ` Qu Wenruo
2023-07-06  7:04                   ` Andrei Borzenkov
2023-07-06  7:07                     ` Qu Wenruo
2023-07-07 20:48                   ` Bernd Lentes
2023-07-07 22:17                     ` Qu Wenruo
2023-06-29  9:12 ` Forza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80136f6f-0575-58e8-ea8d-7053c8af4db0@suse.com \
    --to=wqu@suse.com \
    --cc=bernd.lentes@helmholtz-muenchen.de \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox