Re: [PATCH][v3] btrfs: only search for left_info if there is no right_info

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1632 bytes --]



On 2020/7/30 下午10:02, Josef Bacik wrote:
> On 7/30/20 7:42 AM, Qu Wenruo wrote:
>>
>>
>> On 2020/7/30 上午12:13, David Sterba wrote:
>>> On Wed, Jul 29, 2020 at 11:43:40AM -0400, Josef Bacik wrote:
>>>> On 7/29/20 11:42 AM, Sebastian Döring wrote:
>>>>> For reasons unrelated to btrfs I've been trying linux-next-20200728
>>>>> today.
>>>>>
>>>>> This patch causes Kernel Oops and call trace (with
>>>>> try_merge_free_space on top of stack) on my system. Because of
>>>>> immediate system lock-up I can't provide a dmesg log and there's
>>>>> nothing in /var/log (probably because it immediately goes read-only),
>>>>> but removing this patch and rebuilding the kernel fixed my issues. I'm
>>>>> happy to help if you need more info in order to reproduce.
>>>>>
>>>>
>>>> Lol I literally just hit this and sent the fixup to Dave when you
>>>> posted this.
>>>> My bad, somehow it didn't hit either of us until just now.  Thanks,
>>>
>>> Updated misc-next pushed, for-next will follow.
>>>
>> I guess it's still not working...
>>
>> The latest commit 2f0cb6b46a28 ("btrfs: only search for left_info if
>> there is no right_info in try_merge_free_space"), shows it's now the
>> updated one.
>>
>> But still fails at selftest:
>> https://paste.opensuse.org/41470779
>>
>> Have to revert that commit to do my test...
>>
> 
> I'm looking at misc-next and the commit is
> 
> c5f239232fbe749042e05cae508e1c514ed5bd3c
> 
> Do you have a
> 
> struct btrfs_free_space *left_info = NULL;
> 
> in your tree?  Thanks,
> 
> Josef

Now it's there and no longer crash.

Thanks,
Qu


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]