public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: "Qu Wenruo" <quwenruo.btrfs@gmx.com>,
	dsterba@suse.cz, "Sebastian Döring" <moralapostel@gmail.com>,
	linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH][v3] btrfs: only search for left_info if there is no right_info
Date: Thu, 30 Jul 2020 10:02:41 -0400	[thread overview]
Message-ID: <154a35f8-9a21-371c-1afa-ccf2e90ef316@toxicpanda.com> (raw)
In-Reply-To: <0c64dfd6-7846-babe-b7d2-12decddce4cc@gmx.com>

On 7/30/20 7:42 AM, Qu Wenruo wrote:
> 
> 
> On 2020/7/30 上午12:13, David Sterba wrote:
>> On Wed, Jul 29, 2020 at 11:43:40AM -0400, Josef Bacik wrote:
>>> On 7/29/20 11:42 AM, Sebastian Döring wrote:
>>>> For reasons unrelated to btrfs I've been trying linux-next-20200728 today.
>>>>
>>>> This patch causes Kernel Oops and call trace (with
>>>> try_merge_free_space on top of stack) on my system. Because of
>>>> immediate system lock-up I can't provide a dmesg log and there's
>>>> nothing in /var/log (probably because it immediately goes read-only),
>>>> but removing this patch and rebuilding the kernel fixed my issues. I'm
>>>> happy to help if you need more info in order to reproduce.
>>>>
>>>
>>> Lol I literally just hit this and sent the fixup to Dave when you posted this.
>>> My bad, somehow it didn't hit either of us until just now.  Thanks,
>>
>> Updated misc-next pushed, for-next will follow.
>>
> I guess it's still not working...
> 
> The latest commit 2f0cb6b46a28 ("btrfs: only search for left_info if
> there is no right_info in try_merge_free_space"), shows it's now the
> updated one.
> 
> But still fails at selftest:
> https://paste.opensuse.org/41470779
> 
> Have to revert that commit to do my test...
> 

I'm looking at misc-next and the commit is

c5f239232fbe749042e05cae508e1c514ed5bd3c

Do you have a

struct btrfs_free_space *left_info = NULL;

in your tree?  Thanks,

Josef

  reply	other threads:[~2020-07-30 14:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-27 14:28 [PATCH][v3] btrfs: only search for left_info if there is no right_info Josef Bacik
2020-07-28 14:43 ` David Sterba
2020-07-29 15:42   ` Sebastian Döring
2020-07-29 15:43     ` Josef Bacik
2020-07-29 16:13       ` David Sterba
2020-07-30 11:42         ` Qu Wenruo
2020-07-30 14:02           ` Josef Bacik [this message]
2020-07-30 23:41             ` Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=154a35f8-9a21-371c-1afa-ccf2e90ef316@toxicpanda.com \
    --to=josef@toxicpanda.com \
    --cc=dsterba@suse.cz \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=moralapostel@gmail.com \
    --cc=quwenruo.btrfs@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox