From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: dsterba@suse.cz, Daniel Xu <dxu@dxuuu.xyz>,
linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v2] btrfs-progs: Add basic .editorconfig
Date: Tue, 28 Jul 2020 20:03:09 +0800 [thread overview]
Message-ID: <0ccb18f3-d4eb-9978-b4b6-157cd7c922f0@gmx.com> (raw)
In-Reply-To: <20200728113837.GR3703@twin.jikos.cz>
[-- Attachment #1.1: Type: text/plain, Size: 1261 bytes --]
On 2020/7/28 下午7:38, David Sterba wrote:
> On Mon, Jul 27, 2020 at 06:57:15PM -0700, Daniel Xu wrote:
>> Not all contributors work on projects that use linux kernel coding
>> style. This commit adds a basic editorconfig [0] to assist contributors
>> with managing configuration.
>>
>> [0]: https://editorconfig.org/
>>
>> Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
>> ---
>> Changes from V1:
>> * use tabs instead of spaces
>>
>> .editorconfig | 10 ++++++++++
>> .gitignore | 1 +
>> 2 files changed, 11 insertions(+)
>> create mode 100644 .editorconfig
>>
>> diff --git a/.editorconfig b/.editorconfig
>> new file mode 100644
>> index 00000000..7e15c503
>> --- /dev/null
>> +++ b/.editorconfig
>> @@ -0,0 +1,10 @@
>> +[*]
>> +end_of_line = lf
>> +insert_final_newline = true
>> +trim_trailing_whitespace = true
>
> Does this setting apply on lines that get changed or does it affect the
> whole file? If it's just for the lines, then it's what we want.
>
At least from the vim plugin code, it's just for the new lines:
https://github.com/editorconfig/editorconfig-vim/blob/0a3c1d8082e38a5ebadcba7bb3a608d88a9ff044/plugin/editorconfig.vim#L494
It just call the replace on the current line.
Thanks,
Qu
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-07-28 12:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 1:57 [PATCH v2] btrfs-progs: Add basic .editorconfig Daniel Xu
2020-07-28 1:58 ` Qu Wenruo
2020-07-28 2:23 ` Neal Gompa
2020-07-28 11:38 ` David Sterba
2020-07-28 12:03 ` Qu Wenruo [this message]
2020-07-28 12:12 ` Qu Wenruo
2020-07-28 12:57 ` David Sterba
2020-07-28 13:00 ` Qu Wenruo
2020-07-28 17:26 ` Daniel Xu
2020-07-29 9:59 ` David Sterba
2020-07-28 17:24 ` Daniel Xu
2020-07-29 9:58 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ccb18f3-d4eb-9978-b4b6-157cd7c922f0@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=dsterba@suse.cz \
--cc=dxu@dxuuu.xyz \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox