Re: [PATCH v2] btrfs-progs: Add basic .editorconfig

["Daniel Xu" <dxu@dxuuu.xyz>]

On Tue Jul 28, 2020 at 6:00 AM PDT, Qu Wenruo wrote:
>
>
> On 2020/7/28 下午8:57, David Sterba wrote:
> > On Tue, Jul 28, 2020 at 08:12:40PM +0800, Qu Wenruo wrote:
> >>>>> +trim_trailing_whitespace = true
> >>>>
> >>>> Does this setting apply on lines that get changed or does it affect the
> >>>> whole file? If it's just for the lines, then it's what we want.
> >>>>
> >>> At least from the vim plugin code, it's just for the new lines:
> >>>
> >>> https://github.com/editorconfig/editorconfig-vim/blob/0a3c1d8082e38a5ebadcba7bb3a608d88a9ff044/plugin/editorconfig.vim#L494
> >>>
> >>> It just call the replace on the current line.
> >>
> >> My bad, %s, it replaces all existing lines...
> > 
> > So this would introduce unrelated changes, but it seems that we don't
> > have much trailing whitespaces in progs codebase:
> > 
> >   $ git grep '\s\+$'
> >   btrfs-fragments.c:
> >   btrfs-fragments.c:                              black = gdImageColorAllocate(im, 0, 0, 0);  
> >   crypto/crc32c.c:/* 
> >   crypto/crc32c.c: * 
> >   crypto/crc32c.c: * Software Foundation; either version 2 of the License, or (at your option) 
> >   crypto/crc32c.c: * Steps through buffer one byte at at time, calculates reflected 
> >   crypto/crc32c.c: * Steps through buffer one byte at at time, calculates reflected 
> >   kernel-lib/radix-tree.h: * 
> >   kernel-lib/radix-tree.h: * 
> >   kernel-lib/rbtree.c:            node = node->rb_right; 
> >   kernel-lib/rbtree.c:            node = node->rb_left; 
> >   kernel-lib/rbtree.h:  
> > 
> > filtering only the sources. So let's keep it in the config.
> > 
> Great.
>
> BTW, it would be better to mention we use editorconfig as the unified
> formatting config.
>
> As most of us are using vim, which doesn't support editorconfig by
> default, thus we need to install that plugin manually.

Sure, should a hint about editorconfig go into the `Development` section
of the README.md?