From: Nikolay Borisov <nborisov@suse.com>
To: Chung-Chiang Cheng <cccheng@synology.com>,
dsterba@suse.com, fdmanana@kernel.org
Cc: josef@toxicpanda.com, clm@fb.com, linux-btrfs@vger.kernel.org,
shepjeng@gmail.com, kernel@cccheng.net
Subject: Re: [PATCH 1/2] btrfs: export a helper for compression hard check
Date: Mon, 18 Apr 2022 10:00:09 +0300 [thread overview]
Message-ID: <0d70749d-a10c-a426-7a56-c68e0afeb065@suse.com> (raw)
In-Reply-To: <20220415080406.234967-1-cccheng@synology.com>
On 15.04.22 г. 11:04 ч., Chung-Chiang Cheng wrote:
> inode_can_compress will be used outside of inode.c to check the
> availability of setting compression flag by xattr. This patch moves
> this function as an internal helper and renames it to
> btrfs_inode_can_compress.
>
> Signed-off-by: Chung-Chiang Cheng <cccheng@synology.com>
The whole series LGTM:
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Still, providin an fstest is highly desirable.
next prev parent reply other threads:[~2022-04-18 7:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 8:04 [PATCH 1/2] btrfs: export a helper for compression hard check Chung-Chiang Cheng
2022-04-15 8:04 ` [PATCH 2/2] btrfs: do not allow compression on nodatacow files Chung-Chiang Cheng
2022-04-15 14:03 ` Nikolay Borisov
2022-04-19 15:03 ` Filipe Manana
2022-04-18 7:00 ` Nikolay Borisov [this message]
2022-04-19 15:02 ` [PATCH 1/2] btrfs: export a helper for compression hard check Filipe Manana
2022-04-20 14:49 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d70749d-a10c-a426-7a56-c68e0afeb065@suse.com \
--to=nborisov@suse.com \
--cc=cccheng@synology.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=fdmanana@kernel.org \
--cc=josef@toxicpanda.com \
--cc=kernel@cccheng.net \
--cc=linux-btrfs@vger.kernel.org \
--cc=shepjeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox