public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Mason <chris.mason@oracle.com>
To: Joe Peterson <lavajoe@gentoo.org>
Cc: Josef Bacik <jbacik@redhat.com>,
	Zach Brown <zach.brown@oracle.com>, Mingming <cmm@us.ibm.com>,
	linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] COW and checksumming ioctls
Date: Fri, 20 Jun 2008 12:37:57 -0400	[thread overview]
Message-ID: <1213979877.10187.515.camel@think.oraclecorp.com> (raw)
In-Reply-To: <485BC7AF.6020708@gentoo.org>

On Fri, 2008-06-20 at 09:07 -0600, Joe Peterson wrote:
> Josef Bacik wrote:
> > Database apps that do their own complicated stuff to make sure everything makes
> > it to the disk properly who dont want the extra overhead of checksumming.
> 
> I do see the benefit of that, if indeed the DB does end-to-end checking.
>  Then again, I could almost see that perhaps making the setting based on
> something at the subvolume level (not per-file level) might be even
> better for that case.
> 

But, it'll be common to mix database files with files that you do want
checksummed in the same volume.  This is an admin level decision, and we
can easily provide knobs to turn it on/off.  So, I think the ioctl is
really important and we'll just document it as best we can.

Long term, these might end up getting folded into chattr, so I think
Zach has a good point about folding them into a single
change-file-attributes ioctl.

-chris



  reply	other threads:[~2008-06-20 16:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-20  0:26 [PATCH] COW and checksumming ioctls Mingming
2008-06-20  5:23 ` Zach Brown
2008-06-20 14:01   ` Joe Peterson
2008-06-20 13:58     ` Josef Bacik
2008-06-20 15:07       ` Joe Peterson
2008-06-20 16:37         ` Chris Mason [this message]
2008-06-21  6:07           ` Joe Peterson
2008-06-20 19:44         ` jim owens
2008-06-21  5:59           ` Joe Peterson
2008-06-21  7:27   ` Christoph Hellwig
2008-06-22 14:10     ` Chris Mason
2008-06-22 18:13       ` Joshua J. Berry
2008-06-30 18:38       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1213979877.10187.515.camel@think.oraclecorp.com \
    --to=chris.mason@oracle.com \
    --cc=cmm@us.ibm.com \
    --cc=jbacik@redhat.com \
    --cc=lavajoe@gentoo.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=zach.brown@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox