From: Zach Brown <zach.brown@oracle.com>
To: Mingming <cmm@us.ibm.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] COW and checksumming ioctls
Date: Thu, 19 Jun 2008 22:23:17 -0700 [thread overview]
Message-ID: <485B3EC5.8090006@oracle.com> (raw)
In-Reply-To: <1213921608.27507.152.camel@BVR-FS.beaverton.ibm.com>
> +#define BTRFS_IOC_NODATACOW _IO(BTRFS_IOCTL_MAGIC, 13)
> +#define BTRFS_IOC_DATACOW _IO(BTRFS_IOCTL_MAGIC, 14)
> +#define BTRFS_IOC_NODATASUM _IO(BTRFS_IOCTL_MAGIC, 15)
> +#define BTRFS_IOC_DATASUM _IO(BTRFS_IOCTL_MAGIC, 16)
Hmm. Do we really want 4 different ioctl commands to turn 2 features on
and off? Surely we could have 1 ioctl which updates a bitfield? Or a
ioctl that takes an explicit feature enum argument and a boolean which
indicates that it should be enabled or not?
(And is ioctl the right interface for this? maybe it should be xattr
ops in some defined btrfs string namespace? I'm just making this up. I
feel the the lack of a single comment in the patch, while in keeping
with the existing precedent in btrfs, leaves a lot of room for wild
speculation :))
- z
next prev parent reply other threads:[~2008-06-20 5:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 0:26 [PATCH] COW and checksumming ioctls Mingming
2008-06-20 5:23 ` Zach Brown [this message]
2008-06-20 14:01 ` Joe Peterson
2008-06-20 13:58 ` Josef Bacik
2008-06-20 15:07 ` Joe Peterson
2008-06-20 16:37 ` Chris Mason
2008-06-21 6:07 ` Joe Peterson
2008-06-20 19:44 ` jim owens
2008-06-21 5:59 ` Joe Peterson
2008-06-21 7:27 ` Christoph Hellwig
2008-06-22 14:10 ` Chris Mason
2008-06-22 18:13 ` Joshua J. Berry
2008-06-30 18:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485B3EC5.8090006@oracle.com \
--to=zach.brown@oracle.com \
--cc=cmm@us.ibm.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox