From: David Woodhouse <dwmw2@infradead.org>
To: Chris Mason <chris.mason@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Use do_div() instead of native 64-bit division in btrfs_ordered_sum_size()
Date: Wed, 23 Jul 2008 17:07:04 -0400 [thread overview]
Message-ID: <1216847224.3019.137.camel@shinybook.infradead.org> (raw)
In-Reply-To: <1216819706.6932.146.camel@think.oraclecorp.com>
On Wed, 2008-07-23 at 09:28 -0400, Chris Mason wrote:
> On Wed, 2008-07-23 at 07:13 -0400, Christoph Hellwig wrote:
> > Chris, can you please put this patch in? Without it btrfs can't be
> > loaded on 32bit platforms.
> >
>
> I've pushed out a slightly different fix. The ordered extents are
> based on ram writeback, and so an unsigned long is enough.
Does the job for me, although we still need the
s/BUG_ON(spin_trylock(&tree->lock))/assert_spin_locked(&tree->lock)/
patch I sent a few days ago.
Now I can actually build the module, load it and avoid it hitting a
BUG_ON() when it first tries to mount, I can perhaps move on to doing
something more useful with it... :)
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2008-07-23 21:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 3:32 [PATCH] Use do_div() instead of native 64-bit division in btrfs_ordered_sum_size() David Woodhouse
2008-07-22 3:36 ` kernel BUG at extent_map.c:275! David Woodhouse
2008-07-22 10:21 ` Chris Mason
2008-07-22 14:35 ` David Woodhouse
2008-07-22 17:03 ` Chris Mason
2008-07-22 17:41 ` David Woodhouse
2008-07-22 17:42 ` Zach Brown
2008-07-22 18:04 ` David Woodhouse
2008-07-24 14:34 ` Chris Mason
2008-07-22 18:12 ` Chris Mason
2008-07-22 14:43 ` [PATCH] Remove BUG_ON(spin_trylock()) checks which have false positives on UP David Woodhouse
2008-07-23 11:13 ` [PATCH] Use do_div() instead of native 64-bit division in btrfs_ordered_sum_size() Christoph Hellwig
2008-07-23 13:28 ` Chris Mason
2008-07-23 21:07 ` David Woodhouse [this message]
2008-07-24 0:19 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216847224.3019.137.camel@shinybook.infradead.org \
--to=dwmw2@infradead.org \
--cc=chris.mason@oracle.com \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox