Linux Btrfs filesystem development
 help / color / mirror / Atom feed
* crc32c implementation on x86 with SSE4.2... CONFIG_BTRFS_HW_SUM
@ 2008-10-16 13:40 Miguel Sousa Filipe
  2008-10-16 13:49 ` Chris Mason
  0 siblings, 1 reply; 3+ messages in thread
From: Miguel Sousa Filipe @ 2008-10-16 13:40 UTC (permalink / raw)
  To: linux-btrfs

Hi there,

I noticed that btrfs, in the git tree, has its own implementation of
crc32c for x86 with SSE4.2 that implement a crc32 instruction.. it
appears.
Its protected by a ifdef CONFIG_BTRFS_HW_SUM, and if we're executing
on the right cpu, that will bypass the kernel implementation of
crc32c.

please see: http://git.kernel.org/?p=linux/kernel/git/mason/btrfs-unstable.git;a=blob_plain;f=fs/btrfs/crc32c.h;hb=HEAD

Based on this understanding, should this be a implementation detail of
crc32c, and be correctly implemented (and therefore patched) in the
mainline kernel implementation of crc32c ?

I know that checksumming is cpu expensive, and btrfs wants the best
impl. possible. but that shouldn't be a btrfs issue, that should be
crc32c issue, and its the crc32c implementation that should be fixed,
instead of having our own special crc32c in case we're executing in
the right cpu.

Should I post a patch with this for the vanilla crc32c implementation?

kind regards,

-- 
Miguel Sousa Filipe

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-10-17  6:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-16 13:40 crc32c implementation on x86 with SSE4.2... CONFIG_BTRFS_HW_SUM Miguel Sousa Filipe
2008-10-16 13:49 ` Chris Mason
2008-10-17  6:37   ` Tomasz Torcz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox