public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Mason <chris.mason@oracle.com>
To: Yan Zheng <yanzheng@21cn.com>
Cc: Roland <devzero@web.de>, yanhai zhu <zhu.yanhai@gmail.com>,
	linux-btrfs@vger.kernel.org
Subject: Re: multiple device usage
Date: Tue, 30 Dec 2008 16:43:01 -0500	[thread overview]
Message-ID: <1230673381.4229.7.camel@think.oraclecorp.com> (raw)
In-Reply-To: <3d0408630812290435l7b4739dbi88b8b596df60baab@mail.gmail.com>

On Mon, 2008-12-29 at 20:35 +0800, Yan Zheng wrote:
> 2008/12/29 Roland <devzero@web.de>:
> >>> so i can do btrfs-vol -r /dev/sdb while it`s being mounted, pull the disk
> >>> ,
> >>> replace it with a bigger one, rescan-scsi-bus, mkfs.btrfs the new disk
> >>> and
> >>
> >>                                                ~~~~~~~~~~~~~~~~~~~~~~~
> >>                                               This step will fail, you
> >> will
> >> get a "/dev/sdb is mounted" by mkfs.btrfs, but for other slots it's ok.
> >
> > isn`t this sort of a design issue then?
> > no way to work around this ?
> >
> 
> No, this is a (easy to fix) bug.

Right, the check for a mounted FS came after we made the device
add/removal work ;)  mkfs.btrfs should be changed to do the mounted FS
check differently.

-chris



  reply	other threads:[~2008-12-30 21:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-26 23:15 multiple device usage devzero
2008-12-27  2:44 ` Yan Zheng
2008-12-27 14:12   ` Roland
2008-12-28 13:26     ` yanhai zhu
2008-12-29 10:49       ` Stephan von Krawczynski
2008-12-29 12:31       ` Roland
2008-12-29 12:35         ` Yan Zheng
2008-12-30 21:43           ` Chris Mason [this message]
2008-12-27  6:45 ` Chris Samuel
2008-12-29 11:32   ` Chris Samuel
2008-12-29 12:33     ` Yan Zheng
2008-12-29 12:52       ` Chris Samuel
2008-12-29 15:16         ` Yan Zheng
2008-12-30 21:25           ` Chris Mason
2009-01-01  1:02             ` Chris Samuel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1230673381.4229.7.camel@think.oraclecorp.com \
    --to=chris.mason@oracle.com \
    --cc=devzero@web.de \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=yanzheng@21cn.com \
    --cc=zhu.yanhai@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox