* [PATCH] __must_check btrfs_alloc_path()
@ 2008-12-29 21:02 Diego Calleja
2009-01-05 15:34 ` Chris Mason
0 siblings, 1 reply; 2+ messages in thread
From: Diego Calleja @ 2008-12-29 21:02 UTC (permalink / raw)
To: linux-btrfs
IMHO it's a good thing to add __must_check in new code where it has sense.
Index: btrfs-unstable-standalone/ctree.c
===================================================================
--- btrfs-unstable-standalone.orig/ctree.c 2008-12-29 21:57:15.366588465 +0100
+++ btrfs-unstable-standalone/ctree.c 2008-12-29 21:58:06.878588402 +0100
@@ -43,7 +43,7 @@
memset(p, 0, sizeof(*p));
}
-struct btrfs_path *btrfs_alloc_path(void)
+struct btrfs_path __must_check *btrfs_alloc_path(void)
{
struct btrfs_path *path;
path = kmem_cache_alloc(btrfs_path_cachep, GFP_NOFS);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] __must_check btrfs_alloc_path()
2008-12-29 21:02 [PATCH] __must_check btrfs_alloc_path() Diego Calleja
@ 2009-01-05 15:34 ` Chris Mason
0 siblings, 0 replies; 2+ messages in thread
From: Chris Mason @ 2009-01-05 15:34 UTC (permalink / raw)
To: Diego Calleja; +Cc: linux-btrfs
On Mon, 2008-12-29 at 22:02 +0100, Diego Calleja wrote:
> IMHO it's a good thing to add __must_check in new code where it has sense.
>
>
I don't think we'll pass this one yet ;) But you're right that it is a
good idea to start adding it to other functions.
-chris
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-05 15:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-29 21:02 [PATCH] __must_check btrfs_alloc_path() Diego Calleja
2009-01-05 15:34 ` Chris Mason
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox