* [PATCH] btrfs: remove the improper comment for btrfs_ioctl_resize()
@ 2009-05-04 5:05 Li Hong
2009-05-04 15:11 ` Chris Mason
0 siblings, 1 reply; 2+ messages in thread
From: Li Hong @ 2009-05-04 5:05 UTC (permalink / raw)
To: chris.mason, linux-btrfs; +Cc: lizf, linux-kernel
In Li Zefan's commit dae7b665cf6d6e6e733f1c9c16cf55547dd37e33,
a combination call of kmalloc() and copy_from_user() is replaced by
memdup_user(). So btrfs_ioctl_resize() doesn't use GFP_NOFS any more.
Signed-off-by: Li Hong <lihong.hi@gmail.com>
---
fs/btrfs/ioctl.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index 5e94ea6..2624b53 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -437,10 +437,6 @@ out_unlock:
return 0;
}
-/*
- * Called inside transaction, so use GFP_NOFS
- */
-
static int btrfs_ioctl_resize(struct btrfs_root *root, void __user *arg)
{
u64 new_size;
--
1.6.2.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] btrfs: remove the improper comment for btrfs_ioctl_resize()
2009-05-04 5:05 [PATCH] btrfs: remove the improper comment for btrfs_ioctl_resize() Li Hong
@ 2009-05-04 15:11 ` Chris Mason
0 siblings, 0 replies; 2+ messages in thread
From: Chris Mason @ 2009-05-04 15:11 UTC (permalink / raw)
To: Li Hong; +Cc: linux-btrfs, lizf, linux-kernel
On Mon, 2009-05-04 at 01:05 -0400, Li Hong wrote:
> In Li Zefan's commit dae7b665cf6d6e6e733f1c9c16cf55547dd37e33,
> a combination call of kmalloc() and copy_from_user() is replaced by
> memdup_user(). So btrfs_ioctl_resize() doesn't use GFP_NOFS any more.
>
> Signed-off-by: Li Hong <lihong.hi@gmail.com>
> ---
> fs/btrfs/ioctl.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
> index 5e94ea6..2624b53 100644
> --- a/fs/btrfs/ioctl.c
> +++ b/fs/btrfs/ioctl.c
> @@ -437,10 +437,6 @@ out_unlock:
> return 0;
> }
>
> -/*
> - * Called inside transaction, so use GFP_NOFS
> - */
> -
> static int btrfs_ioctl_resize(struct btrfs_root *root, void __user *arg)
> {
> u64 new_size;
Thanks, I've queued this one up.
-chris
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-04 15:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-04 5:05 [PATCH] btrfs: remove the improper comment for btrfs_ioctl_resize() Li Hong
2009-05-04 15:11 ` Chris Mason
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox