public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Daniel J Blueman <daniel.blueman@gmail.com>
Cc: Chris Mason <chris.mason@oracle.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Linux BTRFS <linux-btrfs@vger.kernel.org>
Subject: Re: [2.6.31-rc6, BTRFS] potential memory leaks...
Date: Sun, 16 Aug 2009 22:38:47 +0100	[thread overview]
Message-ID: <1250458727.8085.6.camel@pc1117.cambridge.arm.com> (raw)
In-Reply-To: <6278d2220908160555m2aba699euf2133e07c1626941@mail.gmail.com>

On Sun, 2009-08-16 at 13:55 +0100, Daniel J Blueman wrote:
> On Fri, Aug 14, 2009 at 5:35 PM, Catalin Marinas<catalin.marinas@arm.com> wrote:
> > Daniel J Blueman <daniel.blueman@gmail.com> wrote:
> >> There is good chance that the BTRFS kmemleak reports using 2.6.31-rc6
> >> [1] are false-positives, due to the overwriting of the static pointers
> >> [2]. Does this ring true with anyone else?
> >
> > If you do a few echo scan > /sys/kernel/debug/kmemleak, do they
> > disappear?
> >
> > The static pointers are scanned by kmemleak, unless they are in the
> > .data.init section (which is removed anyway).
> 
> The above reports I picked _are_ transient indeed.

In earlier versions of kmemleak, a block required two successive
classifications as leak before being reported. Maybe I should go back to
this approach.

> Directed more to LKML, every mount (at least on ext4 and BTRFS), we do
> see persistent reports [1], even after scanning, unmount and more
> scanning.

The ext4 leak is real and a patch was proposed here:
http://lkml.org/lkml/2009/7/15/62

It seems that this patch hasn't been merged into mainline yet (in the
meantime I merged it in my "kmemleak-fixes" branch on
git://linux-arm.org/linux-2.6.git)

-- 
Catalin


      reply	other threads:[~2009-08-16 21:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-14 15:03 [2.6.31-rc6, BTRFS] potential memory leaks Daniel J Blueman
2009-08-14 15:05 ` Chris Mason
2009-08-14 16:35 ` Catalin Marinas
2009-08-16 12:55   ` Daniel J Blueman
2009-08-16 21:38     ` Catalin Marinas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1250458727.8085.6.camel@pc1117.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=chris.mason@oracle.com \
    --cc=daniel.blueman@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox