From: Daniel J Blueman <daniel.blueman@gmail.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
Chris Mason <chris.mason@oracle.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Cc: Linux BTRFS <linux-btrfs@vger.kernel.org>
Subject: Re: [2.6.31-rc6, BTRFS] potential memory leaks...
Date: Sun, 16 Aug 2009 13:55:22 +0100 [thread overview]
Message-ID: <6278d2220908160555m2aba699euf2133e07c1626941@mail.gmail.com> (raw)
In-Reply-To: <tnxab228ibo.fsf@pc1117.cambridge.arm.com>
On Fri, Aug 14, 2009 at 5:35 PM, Catalin Marinas<catalin.marinas@arm.com> wrote:
> Daniel J Blueman <daniel.blueman@gmail.com> wrote:
>> There is good chance that the BTRFS kmemleak reports using 2.6.31-rc6
>> [1] are false-positives, due to the overwriting of the static pointers
>> [2]. Does this ring true with anyone else?
>
> If you do a few echo scan > /sys/kernel/debug/kmemleak, do they
> disappear?
>
> The static pointers are scanned by kmemleak, unless they are in the
> .data.init section (which is removed anyway).
The above reports I picked _are_ transient indeed.
Directed more to LKML, every mount (at least on ext4 and BTRFS), we do
see persistent reports [1], even after scanning, unmount and more
scanning.
Daniel
--- [1]
unreferenced object 0xffff88006133d260 (size 32):
comm "mount", pid 27209, jiffies 4300626089
backtrace:
[<ffffffff810de2f1>] create_object+0x141/0x2d0
[<ffffffff810de5c5>] kmemleak_alloc+0x55/0x60
[<ffffffff810dadfb>] __kmalloc_track_caller+0x17b/0x260
[<ffffffff810c1429>] kstrdup+0x39/0x70
[<ffffffffa01d2b9a>] btrfs_parse_options+0x5a/0x3a0 [btrfs]
[<ffffffffa01edf45>] open_ctree+0x9c5/0x13f0 [btrfs]
[<ffffffffa01d24ec>] btrfs_get_sb+0x3fc/0x500 [btrfs]
[<ffffffff810e2478>] vfs_kern_mount+0x58/0xd0
[<ffffffff810e255e>] do_kern_mount+0x4e/0x110
[<ffffffff810fc55a>] do_mount+0x2ca/0x8d0
[<ffffffff810fcc1b>] sys_mount+0xbb/0xf0
[<ffffffff8100bdeb>] system_call_fastpath+0x16/0x1b
unreferenced object 0xffff88007a5d9c80 (size 128):
comm "mount", pid 2030, jiffies 4294963872
backtrace:
[<ffffffff810de2f1>] create_object+0x141/0x2d0
[<ffffffff810de5c5>] kmemleak_alloc+0x55/0x60
[<ffffffff810da14b>] __kmalloc+0x18b/0x270
[<ffffffff81162c8d>] ext4_mb_init+0x1cd/0x670
[<ffffffff8114e363>] ext4_fill_super+0x1883/0x2810
[<ffffffff810e388d>] get_sb_bdev+0x17d/0x1b0
[<ffffffff8114a8c3>] ext4_get_sb+0x13/0x20
[<ffffffff810e2478>] vfs_kern_mount+0x58/0xd0
[<ffffffff810e255e>] do_kern_mount+0x4e/0x110
[<ffffffff810fc55a>] do_mount+0x2ca/0x8d0
[<ffffffff810fcc1b>] sys_mount+0xbb/0xf0
[<ffffffff8100bdeb>] system_call_fastpath+0x16/0x1b
unreferenced object 0xffff88006071a000 (size 8192):
comm "mount", pid 27460, jiffies 4303151389
backtrace:
[<ffffffff810de2f1>] create_object+0x141/0x2d0
[<ffffffff810de5c5>] kmemleak_alloc+0x55/0x60
[<ffffffff810d9f73>] kmem_cache_alloc+0x153/0x1a0
[<ffffffff81171ec7>] journal_init_common+0x1e7/0x2a0
[<ffffffff81172995>] jbd2_journal_init_inode+0x15/0x1b0
[<ffffffff8114e869>] ext4_fill_super+0x1d89/0x2810
[<ffffffff810e388d>] get_sb_bdev+0x17d/0x1b0
[<ffffffff8114a8c3>] ext4_get_sb+0x13/0x20
[<ffffffff810e2478>] vfs_kern_mount+0x58/0xd0
[<ffffffff810e255e>] do_kern_mount+0x4e/0x110
[<ffffffff810fc55a>] do_mount+0x2ca/0x8d0
[<ffffffff810fcc1b>] sys_mount+0xbb/0xf0
[<ffffffff8100bdeb>] system_call_fastpath+0x16/0x1b
--
Daniel J Blueman
next prev parent reply other threads:[~2009-08-16 12:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-14 15:03 [2.6.31-rc6, BTRFS] potential memory leaks Daniel J Blueman
2009-08-14 15:05 ` Chris Mason
2009-08-14 16:35 ` Catalin Marinas
2009-08-16 12:55 ` Daniel J Blueman [this message]
2009-08-16 21:38 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6278d2220908160555m2aba699euf2133e07c1626941@mail.gmail.com \
--to=daniel.blueman@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox