* [PATCH] Btrfs-progs: Relocate -lpthread in makefile
@ 2011-11-14 15:47 Arnd Hannemann
2011-11-14 15:57 ` Jan Schmidt
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Hannemann @ 2011-11-14 15:47 UTC (permalink / raw)
To: linux-btrfs; +Cc: chris.mason, Arnd Hannemann
This patch fixes the following compile error when compiled with
gcc version 4.6.1 (Ubuntu/Linaro 4.6.1-9ubuntu3):
gcc -lpthread -g -O0 -o btrfs btrfs.o btrfs_cmds.o scrub.o \
ctree.o disk-io.o radix-tree.o extent-tree.o print-tree.o root-tree.o dir-item.o file-item.o inode-item.o inode-map.o crc32c.o rbtree.o extent-cache.o extent_io.o volumes.o utils.o btrfs-list.o btrfslabel.o -luuid
scrub.o: In function `scrub_start':
/home/arnd/Projekte/kernel/btrfs-progs/scrub.c:1342: undefined reference to `pthread_create'
/home/arnd/Projekte/kernel/btrfs-progs/scrub.c:1360: undefined reference to `pthread_create'
/home/arnd/Projekte/kernel/btrfs-progs/scrub.c:1374: undefined reference to `pthread_join'
/home/arnd/Projekte/kernel/btrfs-progs/scrub.c:1430: undefined reference to `pthread_cancel'
/home/arnd/Projekte/kernel/btrfs-progs/scrub.c:1432: undefined reference to `pthread_join'
collect2: ld returned 1 exit status
make: *** [btrfs] Error 1
The gcc man page says: "[...] the placement of the -l option is significant." so lets include -lpthread together with the usual $(LIBS)
Signed-off-by: Arnd Hannemann <arnd@arndnet.de>
---
Makefile | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 96e2002..834be47 100644
--- a/Makefile
+++ b/Makefile
@@ -37,8 +37,8 @@ version:
bash version.sh
btrfs: $(objects) btrfs.o btrfs_cmds.o scrub.o
- $(CC) -lpthread $(CFLAGS) -o btrfs btrfs.o btrfs_cmds.o scrub.o \
- $(objects) $(LDFLAGS) $(LIBS)
+ $(CC) $(CFLAGS) -o btrfs btrfs.o btrfs_cmds.o scrub.o \
+ $(objects) $(LDFLAGS) $(LIBS) -lpthread
calc-size: $(objects) calc-size.o
gcc $(CFLAGS) -o calc-size calc-size.o $(objects) $(LDFLAGS) $(LIBS)
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Btrfs-progs: Relocate -lpthread in makefile
2011-11-14 15:47 [PATCH] Btrfs-progs: Relocate -lpthread in makefile Arnd Hannemann
@ 2011-11-14 15:57 ` Jan Schmidt
0 siblings, 0 replies; 2+ messages in thread
From: Jan Schmidt @ 2011-11-14 15:57 UTC (permalink / raw)
To: Arnd Hannemann, David Sterba; +Cc: linux-btrfs, chris.mason, Sergei Trofimovich
On 14.11.2011 16:47, Arnd Hannemann wrote:
> This patch fixes the following compile error when compiled with
> gcc version 4.6.1 (Ubuntu/Linaro 4.6.1-9ubuntu3):
>
> gcc -lpthread -g -O0 -o btrfs btrfs.o btrfs_cmds.o scrub.o \
> ctree.o disk-io.o radix-tree.o extent-tree.o print-tree.o root-tree.o dir-item.o file-item.o inode-item.o inode-map.o crc32c.o rbtree.o extent-cache.o extent_io.o volumes.o utils.o btrfs-list.o btrfslabel.o -luuid
> scrub.o: In function `scrub_start':
> /home/arnd/Projekte/kernel/btrfs-progs/scrub.c:1342: undefined reference to `pthread_create'
> /home/arnd/Projekte/kernel/btrfs-progs/scrub.c:1360: undefined reference to `pthread_create'
> /home/arnd/Projekte/kernel/btrfs-progs/scrub.c:1374: undefined reference to `pthread_join'
> /home/arnd/Projekte/kernel/btrfs-progs/scrub.c:1430: undefined reference to `pthread_cancel'
> /home/arnd/Projekte/kernel/btrfs-progs/scrub.c:1432: undefined reference to `pthread_join'
> collect2: ld returned 1 exit status
> make: *** [btrfs] Error 1
>
> The gcc man page says: "[...] the placement of the -l option is significant." so lets include -lpthread together with the usual $(LIBS)
>
> Signed-off-by: Arnd Hannemann <arnd@arndnet.de>
Signed-off-by: Jan Schmidt <list.btrfs@jan-o-sch.net>
Sergei also sent this patch a week ago. I agree with you. David, do you
want to investigate the -pthread option?
-Jan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-14 15:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-14 15:47 [PATCH] Btrfs-progs: Relocate -lpthread in makefile Arnd Hannemann
2011-11-14 15:57 ` Jan Schmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox