From: Robert Marklund <robbelibobban@gmail.com>
To: linux-btrfs@vger.kernel.org
Cc: Robert Marklund <robbelibobban@gmail.com>
Subject: [PATCH] check: check so offset is not bigger then the leaf
Date: Thu, 18 Jun 2015 01:59:13 +0200 [thread overview]
Message-ID: <1434585553-8697-1-git-send-email-robbelibobban@gmail.com> (raw)
This could crash before because of dangerous dangling
offset of pointer.
Signed-off-by: Robert Marklund <robbelibobban@gmail.com>
---
cmds-check.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/cmds-check.c b/cmds-check.c
index 778f141..da36758 100644
--- a/cmds-check.c
+++ b/cmds-check.c
@@ -8906,6 +8906,16 @@ static int build_roots_info_cache(struct btrfs_fs_info *info)
goto next;
ei = btrfs_item_ptr(leaf, slot, struct btrfs_extent_item);
+
+ if ((long long)ei > info->extent_root->leafsize) {
+ fprintf(stderr, "Bad leaf = %p, slot = %d\n", leaf, slot);
+ fprintf(stderr, "item ptr = %p\n", ei);
+ fprintf(stderr, "objectid = %llx\n", found_key.objectid);
+ fprintf(stderr, "type = %x\n", found_key.type);
+ fprintf(stderr, "offset = %llx\n", found_key.offset);
+ goto next;
+ }
+
flags = btrfs_extent_flags(leaf, ei);
if (found_key.type == BTRFS_EXTENT_ITEM_KEY &&
--
2.1.0
next reply other threads:[~2015-06-18 0:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 23:59 Robert Marklund [this message]
2015-06-18 16:44 ` [PATCH] check: check so offset is not bigger then the leaf David Sterba
2015-06-18 17:16 ` Josef Bacik
2015-06-25 16:06 ` David Sterba
2015-06-25 16:24 ` Josef Bacik
2015-06-25 16:49 ` David Sterba
2015-06-29 11:16 ` Trollkarlen Marklund
2015-07-01 13:26 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434585553-8697-1-git-send-email-robbelibobban@gmail.com \
--to=robbelibobban@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox