From: Josef Bacik <jbacik@fb.com>
To: <dsterba@suse.cz>, Robert Marklund <robbelibobban@gmail.com>,
<linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] check: check so offset is not bigger then the leaf
Date: Thu, 18 Jun 2015 10:16:54 -0700 [thread overview]
Message-ID: <5582FD06.2010004@fb.com> (raw)
In-Reply-To: <20150618164443.GH6761@twin.jikos.cz>
On 06/18/2015 09:44 AM, David Sterba wrote:
> On Thu, Jun 18, 2015 at 01:59:13AM +0200, Robert Marklund wrote:
>> This could crash before because of dangerous dangling
>> offset of pointer.
>
> That's right, this can happen. There are more btrfs_item_ptr that would
> be good to validate that way, namely in the checker as it's most likely
> to see corrupted data.
>
The check_block stuff should be doing this, if it isn't that's where we
need to fix it. Thanks,
Josef
next prev parent reply other threads:[~2015-06-18 17:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 23:59 [PATCH] check: check so offset is not bigger then the leaf Robert Marklund
2015-06-18 16:44 ` David Sterba
2015-06-18 17:16 ` Josef Bacik [this message]
2015-06-25 16:06 ` David Sterba
2015-06-25 16:24 ` Josef Bacik
2015-06-25 16:49 ` David Sterba
2015-06-29 11:16 ` Trollkarlen Marklund
2015-07-01 13:26 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5582FD06.2010004@fb.com \
--to=jbacik@fb.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=robbelibobban@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox