From: Johannes Thumshirn <jthumshirn@suse.de>
To: Nikolay Borisov <nborisov@suse.com>,
Anand Jain <anand.jain@oracle.com>,
David Sterba <dsterba@suse.com>
Cc: rbrown@suse.de, Linux BTRFS Mailinglist <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs-progs: warn users about the possible dangers of check --repair
Date: Thu, 17 Oct 2019 09:10:05 +0200 [thread overview]
Message-ID: <148880c2-5e9a-12bd-0c05-dd0e66dca147@suse.de> (raw)
In-Reply-To: <a727c9e1-1db7-de0f-15a4-83578e5cbf93@suse.com>
On 17/10/2019 08:40, Nikolay Borisov wrote:
[...]
>> Agreed. -f will suffice (at least make it non-default) is a good fix.
>> But again as Qu pointed out our test cases will fail or old test case
>> with new progs will fail.
>
> They could be adjusted accordingly to always append the -f flag when
> running --repair. After all when running tests we do expect to be able
> to fix everything, no ?
Agreed
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@suse.de +49 911 74053 689
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5
90409 Nürnberg
Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2019-10-17 7:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 14:05 [PATCH] btrfs-progs: warn users about the possible dangers of check --repair Johannes Thumshirn
2019-10-16 14:18 ` Qu Wenruo
2019-10-16 14:31 ` Nikolay Borisov
2019-10-17 1:25 ` Anand Jain
2019-10-17 6:40 ` Nikolay Borisov
2019-10-17 7:10 ` Johannes Thumshirn [this message]
2019-10-17 7:13 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=148880c2-5e9a-12bd-0c05-dd0e66dca147@suse.de \
--to=jthumshirn@suse.de \
--cc=anand.jain@oracle.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=rbrown@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox