From: Johannes Thumshirn <jthumshirn@suse.de>
To: David Sterba <dsterba@suse.com>
Cc: Linux BTRFS Mailinglist <linux-btrfs@vger.kernel.org>,
rbrown@suse.de, Johannes Thumshirn <jthumshirn@suse.de>
Subject: [PATCH] btrfs-progs: warn users about the possible dangers of check --repair
Date: Wed, 16 Oct 2019 16:05:33 +0200 [thread overview]
Message-ID: <20191016140533.10583-1-jthumshirn@suse.de> (raw)
The manual page of btrfsck clearly states 'btrfs check --repair' is a
dangerous operation.
Although this warning is in place users do not read the manual page and/or
are used to the behaviour of fsck utilities which repair the filesystem,
and thus potentially cause harm.
Similar to 'btrfs balance' without any filters, add a warning and a
countdown, so users can bail out before eventual corrupting the filesystem
more than it already is.
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
---
check/main.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/check/main.c b/check/main.c
index fd05430c1f51..acded927281a 100644
--- a/check/main.c
+++ b/check/main.c
@@ -9970,6 +9970,23 @@ static int cmd_check(const struct cmd_struct *cmd, int argc, char **argv)
exit(1);
}
+ if (repair) {
+ int delay = 10;
+ printf("WARNING:\n\n");
+ printf("\tDo not use --repair unless you are advised to do so by a developer\n");
+ printf("\tor an experienced user, and then only after having accepted that no\n");
+ printf("\tfsck successfully repair all types of filesystem corruption. Eg.\n");
+ printf("\tsome other software or hardware bugs can fatally damage a volume.\n");
+ printf("\tThe operation will start in %d seconds.\n", delay);
+ printf("\tUse Ctrl-C to stop it.\n");
+ while (delay) {
+ printf("%2d", delay--);
+ fflush(stdout);
+ sleep(1);
+ }
+ printf("\nStarting repair.\n");
+ }
+
/*
* experimental and dangerous
*/
--
2.16.4
next reply other threads:[~2019-10-16 14:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 14:05 Johannes Thumshirn [this message]
2019-10-16 14:18 ` [PATCH] btrfs-progs: warn users about the possible dangers of check --repair Qu Wenruo
2019-10-16 14:31 ` Nikolay Borisov
2019-10-17 1:25 ` Anand Jain
2019-10-17 6:40 ` Nikolay Borisov
2019-10-17 7:10 ` Johannes Thumshirn
2019-10-17 7:13 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016140533.10583-1-jthumshirn@suse.de \
--to=jthumshirn@suse.de \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=rbrown@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox