Re: [PATCH v2 0/4] btrfs: Add write time super block validation

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1550 bytes --]



On 2018年05月10日 22:43, David Sterba wrote:
> On Tue, Apr 24, 2018 at 12:48:05PM +0800, Qu Wenruo wrote:
>> This patchset can be fetched from github:
>> https://github.com/adam900710/linux/tree/write_time_sb_check
>>
>> We have 2 reports about corrupted btrfs super block, which has some garbage
>> in its super block, but otherwise it's completely fine and its csum even
>> matches.
>>
>> This means we develop memory corruption during btrfs mount time.
>> It's not clear whether it's caused by btrfs or some other kernel module,
>> but at least let's do write time verification to catch such corruption
>> early.
>>
>> Changelog:
>> v2:
>>   Rename btrfs_check_super_valid() to btrfs_validate_super() suggested
>>   by Nikolay and David.
>>
>> Qu Wenruo (4):
>>   btrfs: Rename btrfs_check_super_valid() to btrfs_validate_super()
>>   btrfs: Add incompat flags check for btrfs_check_super_valid()
>>   btrfs: Add csum type check for btrfs_check_super_valid()
>>   btrfs: Do super block verification before writing it to disk
> 
> IIRC there were some comments about the overal structure of the checks,
> but I can't find V3 of the patchset. Can you please resend it or point
> me to it in case I missed it? Thanks.

Sorry, forgot to update the patchset, would send them out soon.

Thanks,
Qu

> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]