public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 0/4] btrfs: Add write time super block validation
Date: Thu, 10 May 2018 16:43:13 +0200	[thread overview]
Message-ID: <20180510144313.GL6649@twin.jikos.cz> (raw)
In-Reply-To: <20180424044809.29838-1-wqu@suse.com>

On Tue, Apr 24, 2018 at 12:48:05PM +0800, Qu Wenruo wrote:
> This patchset can be fetched from github:
> https://github.com/adam900710/linux/tree/write_time_sb_check
> 
> We have 2 reports about corrupted btrfs super block, which has some garbage
> in its super block, but otherwise it's completely fine and its csum even
> matches.
> 
> This means we develop memory corruption during btrfs mount time.
> It's not clear whether it's caused by btrfs or some other kernel module,
> but at least let's do write time verification to catch such corruption
> early.
> 
> Changelog:
> v2:
>   Rename btrfs_check_super_valid() to btrfs_validate_super() suggested
>   by Nikolay and David.
> 
> Qu Wenruo (4):
>   btrfs: Rename btrfs_check_super_valid() to btrfs_validate_super()
>   btrfs: Add incompat flags check for btrfs_check_super_valid()
>   btrfs: Add csum type check for btrfs_check_super_valid()
>   btrfs: Do super block verification before writing it to disk

IIRC there were some comments about the overal structure of the checks,
but I can't find V3 of the patchset. Can you please resend it or point
me to it in case I missed it? Thanks.

  parent reply	other threads:[~2018-05-10 14:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24  4:48 [PATCH v2 0/4] btrfs: Add write time super block validation Qu Wenruo
2018-04-24  4:48 ` [PATCH v2 1/4] btrfs: Rename btrfs_check_super_valid() to btrfs_validate_super() Qu Wenruo
2018-04-24  4:48 ` [PATCH v2 2/4] btrfs: Add incompat flags check for btrfs_check_super_valid() Qu Wenruo
2018-04-24 10:48   ` David Sterba
2018-04-24 11:28     ` Qu Wenruo
2018-04-24 11:30       ` David Sterba
2018-04-24 12:03         ` Qu Wenruo
2018-04-24  4:48 ` [PATCH v2 3/4] btrfs: Add csum type " Qu Wenruo
2018-04-24  4:48 ` [PATCH v2 4/4] btrfs: Do super block verification before writing it to disk Qu Wenruo
2018-04-24 13:14   ` David Sterba
2018-05-10 14:43 ` David Sterba [this message]
2018-05-11  2:57   ` [PATCH v2 0/4] btrfs: Add write time super block validation Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180510144313.GL6649@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox