From: Josef Bacik <josef@toxicpanda.com>
To: Nikolay Borisov <nborisov@suse.com>,
linux-btrfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH v2] btrfs: Update btrfs/215
Date: Mon, 7 Dec 2020 11:36:23 -0500 [thread overview]
Message-ID: <1c23bd14-3c30-603f-0014-a1aeeb8ef8ab@toxicpanda.com> (raw)
In-Reply-To: <20201207092318.950548-1-nborisov@suse.com>
On 12/7/20 4:23 AM, Nikolay Borisov wrote:
> This patch updates btrfs/215 to work with latest upstream kernel. That's
> required since commit 324bcf54c449 ("mm: use limited read-ahead to satisfy read")
> changed readahead logic to always issue a read even if the RA pages are
> set to 0. This results in 1 extra io being issued so the counts in the
> test should be incremented by 1. Also use the opportunity to update the
> commit reference since it's been merged in the upstream kernel.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---
> V2:
> * Updated comment above buffered read issue command to better describe why 2
> failures are expected.
Do we want to just test for non-zero, since the original problem was that we
weren't getting any error stats at all? Then we don't have to worry about new
edge cases in the future. Thanks,
Josef
next prev parent reply other threads:[~2020-12-07 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 9:23 [PATCH v2] btrfs: Update btrfs/215 Nikolay Borisov
2020-12-07 16:36 ` Josef Bacik [this message]
2020-12-08 8:15 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c23bd14-3c30-603f-0014-a1aeeb8ef8ab@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox