Re: [PATCH v2] btrfs: Update btrfs/215

[Nikolay Borisov <nborisov@suse.com>]

On 7.12.20 г. 18:36 ч., Josef Bacik wrote:
> On 12/7/20 4:23 AM, Nikolay Borisov wrote:
>> This patch updates btrfs/215 to work with latest upstream kernel. That's
>> required since commit 324bcf54c449 ("mm: use limited read-ahead to
>> satisfy read")
>> changed readahead logic to always issue a read even if the RA pages are
>> set to 0. This results in 1 extra io being issued so the counts in the
>> test should be incremented by 1. Also use the opportunity to update the
>> commit reference since it's been merged in the upstream kernel.
>>
>> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
>> ---
>> V2:
>>   * Updated comment above buffered read issue command to better
>> describe why 2
>>   failures are expected.
> 
> Do we want to just test for non-zero, since the original problem was
> that we weren't getting any error stats at all?  Then we don't have to
> worry about new edge cases in the future.  Thanks,


I'da rather have precise numbers so that when something changes and the
test blips red I can go and do a targeted investigation. Esp. with the
subapge rework pending.

> 
> Josef
>