From: Nick Piggin <npiggin@suse.de>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: "Yan, Zheng " <yanzheng@21cn.com>,
Chris Mason <chris.mason@oracle.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [patch] btrfs: fix inode rbtree corruption
Date: Wed, 19 Aug 2009 10:52:08 +0200 [thread overview]
Message-ID: <20090819085208.GF25721@wotan.suse.de> (raw)
In-Reply-To: <20090819084658.GT12579@kernel.dk>
On Wed, Aug 19, 2009 at 10:46:59AM +0200, Jens Axboe wrote:
> On Wed, Aug 19 2009, Nick Piggin wrote:
> > See my other reply. It *can* work with key aliases, but this particular
> > code does not.
> >
> > It is pretty easy obviously to put in duplicates because the rbtree
> > code doesn't know about keys, but if we do this then it looks like
> > it might cause the search code to miss some valid inodes and instead
> > return freeing inodes -- so you'd also have to look at that and update
> > it which is why I didn't go down this route..
>
> Mine was just a generic statement, I didn't read the btrfs code (hence
> my comment about potential lookup bug, if you allow aliases you have to
> be careful).
Ah ok. Well yeah in this case btrfs is definitely wrong in the way it
tried to insert aliases.
next prev parent reply other threads:[~2009-08-19 8:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 16:45 [patch] btrfs: fix inode rbtree corruption Nick Piggin
2009-08-18 18:56 ` Yan, Zheng
2009-08-18 21:19 ` Jens Axboe
2009-08-19 8:45 ` Nick Piggin
2009-08-19 8:46 ` Jens Axboe
2009-08-19 8:52 ` Nick Piggin [this message]
2009-08-19 8:59 ` Jens Axboe
2009-08-20 13:23 ` Nick Piggin
2009-08-20 13:51 ` Yan, Zheng
2009-08-20 22:07 ` Jens Axboe
2009-08-21 0:55 ` Yan, Zheng
2009-08-21 6:20 ` Jens Axboe
2009-08-21 8:06 ` Yan, Zheng
2009-08-21 8:10 ` Jens Axboe
2009-08-19 8:56 ` Yan, Zheng
2009-08-19 9:04 ` Nick Piggin
2009-08-19 9:34 ` Yan, Zheng
2009-08-19 10:47 ` Nick Piggin
2009-08-19 12:00 ` Yan, Zheng
2009-08-19 8:32 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090819085208.GF25721@wotan.suse.de \
--to=npiggin@suse.de \
--cc=chris.mason@oracle.com \
--cc=jens.axboe@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=yanzheng@21cn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox